> > I tried to split this one into many commits, but I wasn't sure it
> > was worth to make a mini-series out of one function. In retrospect
> > it was.
>
> Review of a long series is unrewarding when the patches are all
> perfect ;)
LOL, will split the patch anyway.
Paolo
Paolo Bonzini writes:
> Il 17/10/2012 17:17, Markus Armbruster ha scritto:
>>> > +fail:
>>> > +if (!error_is_set(errp)) {
>>> > +error_set(errp, QERR_VNC_SERVER_FAILED, display);
>> How can we get here with no error set?
>>
>> 1. !vnc_display (first goto fail).
>
> This can be fixed
Il 17/10/2012 17:17, Markus Armbruster ha scritto:
>> > +fail:
>> > +if (!error_is_set(errp)) {
>> > +error_set(errp, QERR_VNC_SERVER_FAILED, display);
> How can we get here with no error set?
>
> 1. !vnc_display (first goto fail).
This can be fixed up to give a separate error.
> 2.
Paolo Bonzini writes:
> Before:
>
> $ qemu-system-x86_64 -vnc foo.bar:12345
> getaddrinfo(foo.bar,18245): Name or service not known
> Failed to start VNC server on `foo.bar:12345'
>
> $ qemu-system-x86_64 -vnc localhost:12345,reverse=on
> inet_connect_opts: connect(ipv4,yakj.u
Before:
$ qemu-system-x86_64 -vnc foo.bar:12345
getaddrinfo(foo.bar,18245): Name or service not known
Failed to start VNC server on `foo.bar:12345'
$ qemu-system-x86_64 -vnc localhost:12345,reverse=on
inet_connect_opts: connect(ipv4,yakj.usersys.redhat.com,127.0.0.1,12345):
C
