Re: [Qemu-devel] [PATCH 14/14] target-i386: Enable XCR0 features for user-mode

2015-07-10 Thread Paolo Bonzini
On 10/07/2015 09:24, Richard Henderson wrote: > On 07/09/2015 02:15 PM, Paolo Bonzini wrote: >> On 09/07/2015 10:17, Richard Henderson wrote: >>> + >>> +/* ??? This variable is somewhat silly. Methinks KVM should be >>> + using XCR0 to store into the XSTATE_BV field. Either that or >>

Re: [Qemu-devel] [PATCH 14/14] target-i386: Enable XCR0 features for user-mode

2015-07-10 Thread Richard Henderson
On 07/09/2015 02:15 PM, Paolo Bonzini wrote: On 09/07/2015 10:17, Richard Henderson wrote: + +/* ??? This variable is somewhat silly. Methinks KVM should be + using XCR0 to store into the XSTATE_BV field. Either that or + there's more missing information, e.g. the AVX bits. */

Re: [Qemu-devel] [PATCH 14/14] target-i386: Enable XCR0 features for user-mode

2015-07-09 Thread Paolo Bonzini
On 09/07/2015 10:17, Richard Henderson wrote: > + > +/* ??? This variable is somewhat silly. Methinks KVM should be > + using XCR0 to store into the XSTATE_BV field. Either that or > + there's more missing information, e.g. the AVX bits. */ > +env->xstate_bv = XSTATE_FP; >

[Qemu-devel] [PATCH 14/14] target-i386: Enable XCR0 features for user-mode

2015-07-09 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target-i386/cpu.c | 22 -- 1 file changed, 20 insertions(+), 2 deletions(-) diff --git a/target-i386/cpu.c b/target-i386/cpu.c index c19ff8a..2402c2a 100644 --- a/target-i386/cpu.c +++ b/target-i386/cpu.c @@ -2654,7 +2654,17 @@ static void