Re: [Qemu-devel] [PATCH 14/16] cadence_gem: avoid stack-writing buffer-overrun

2012-06-19 Thread Peter Crosthwaite
I re-sent this yesterday to trivial. May end up getting queued for merge twice. On Tue, Jun 19, 2012 at 11:31 PM, Peter Maydell wrote: > From: Jim Meyering > > Use sizeof(rxbuf)-size (not sizeof(rxbuf-size)) as the number > of bytes to clear.  The latter would always clear 4 or 8 > bytes, possi

[Qemu-devel] [PATCH 14/16] cadence_gem: avoid stack-writing buffer-overrun

2012-06-19 Thread Peter Maydell
From: Jim Meyering Use sizeof(rxbuf)-size (not sizeof(rxbuf-size)) as the number of bytes to clear. The latter would always clear 4 or 8 bytes, possibly writing beyond the end of that stack buffer. Alternatively, depending on the value of the "size" parameter, it could fail to initialize the end