Re: [Qemu-devel] [PATCH 14/19] nbd/server: nbd_negotiate: return 1 on NBD_OPT_ABORT

2017-06-02 Thread Vladimir Sementsov-Ogievskiy
02.06.2017 15:55, Vladimir Sementsov-Ogievskiy wrote: 02.06.2017 01:33, Eric Blake wrote: On 05/30/2017 09:30 AM, Vladimir Sementsov-Ogievskiy wrote: Separate case when client sent NBD_OPT_ABORT from other errors. It will be needed for the following patch, where errors will be reported.

Re: [Qemu-devel] [PATCH 14/19] nbd/server: nbd_negotiate: return 1 on NBD_OPT_ABORT

2017-06-02 Thread Vladimir Sementsov-Ogievskiy
02.06.2017 01:33, Eric Blake wrote: On 05/30/2017 09:30 AM, Vladimir Sementsov-Ogievskiy wrote: Separate case when client sent NBD_OPT_ABORT from other errors. It will be needed for the following patch, where errors will be reported. Considered case is not actually the error - it honestly

Re: [Qemu-devel] [PATCH 14/19] nbd/server: nbd_negotiate: return 1 on NBD_OPT_ABORT

2017-06-01 Thread Eric Blake
On 05/30/2017 09:30 AM, Vladimir Sementsov-Ogievskiy wrote: > Separate case when client sent NBD_OPT_ABORT from other errors. > It will be needed for the following patch, where errors will be > reported. > Considered case is not actually the error - it honestly follows NBD > protocol. Therefore it

[Qemu-devel] [PATCH 14/19] nbd/server: nbd_negotiate: return 1 on NBD_OPT_ABORT

2017-05-30 Thread Vladimir Sementsov-Ogievskiy
Separate case when client sent NBD_OPT_ABORT from other errors. It will be needed for the following patch, where errors will be reported. Considered case is not actually the error - it honestly follows NBD protocol. Therefore it should not be reported like an error. -EPIPE case means client not