Re: [Qemu-devel] [PATCH 14/21] qapi: Make string input and opts visitor require non-null input

2017-02-25 Thread Eric Blake
On 02/23/2017 03:45 PM, Markus Armbruster wrote: > The string input visitor tries to cope with null input. Null input > isn't used anywhere, and isn't covered by tests. Unsurprisingly, it > doesn't fully work: start_list() crashes because it passes the input > via parse_str() to strtoll() uncheck

[Qemu-devel] [PATCH 14/21] qapi: Make string input and opts visitor require non-null input

2017-02-23 Thread Markus Armbruster
The string input visitor tries to cope with null input. Null input isn't used anywhere, and isn't covered by tests. Unsurprisingly, it doesn't fully work: start_list() crashes because it passes the input via parse_str() to strtoll() unchecked. Make string_input_visitor_new() assert its argument