Re: [Qemu-devel] [PATCH 14/22] qapi: add query-version QMP command

2011-03-10 Thread Avi Kivity
On 03/10/2011 02:41 PM, Avi Kivity wrote: I don't think I want to make this sort of change just yet. Also note that the schema that will be exposed over the wire is not directly related to the schema we use for code generation. Right, we have to nail down the format for the former, though.

Re: [Qemu-devel] [PATCH 14/22] qapi: add query-version QMP command

2011-03-10 Thread Avi Kivity
On 03/09/2011 04:47 PM, Anthony Liguori wrote: [ { 'type': 'MyType', fields: [['a', 'str'], ['b', 'int'], ['c', 'AnotherType']] } { 'event': 'MY_EVENT', 'arguments': [ ... ] } { 'command': 'my-command', 'arguments': [ ... ], 'return': ... } ] which leaves us room for additional

Re: [Qemu-devel] [PATCH 14/22] qapi: add query-version QMP command

2011-03-09 Thread Avi Kivity
On 03/07/2011 03:41 PM, Anthony Liguori wrote: On 03/07/2011 07:35 AM, Stefan Hajnoczi wrote: On Mon, Mar 7, 2011 at 1:22 AM, Anthony Liguorialigu...@us.ibm.com wrote: diff --git a/qmp-schema.json b/qmp-schema.json index e69de29..b343f5e 100644 --- a/qmp-schema.json +++ b/qmp-schema.json @@

Re: [Qemu-devel] [PATCH 14/22] qapi: add query-version QMP command

2011-03-09 Thread Avi Kivity
On 03/07/2011 03:22 AM, Anthony Liguori wrote: This is used internally by QMP. It's also a pretty good example of a typical command conversion. +## +{ 'VersionInfo': {'qemu': {'major': 'int', 'minor': 'int', 'micro': 'int'}, + 'package': 'str'} } + +## +# @query-version: +# +#

Re: [Qemu-devel] [PATCH 14/22] qapi: add query-version QMP command

2011-03-09 Thread Avi Kivity
On 03/09/2011 03:44 PM, Anthony Liguori wrote: Yeah, it's only loosely JSON as I don't use a JSON parser. Goes kind of against all the buzzwords you're letting fly here... The schema defines arguments in a dictionary because in QMP, the argument order doesn't matter. But the argument

Re: [Qemu-devel] [PATCH 14/22] qapi: add query-version QMP command

2011-03-07 Thread Stefan Hajnoczi
On Mon, Mar 7, 2011 at 1:22 AM, Anthony Liguori aligu...@us.ibm.com wrote: diff --git a/qmp-schema.json b/qmp-schema.json index e69de29..b343f5e 100644 --- a/qmp-schema.json +++ b/qmp-schema.json @@ -0,0 +1,38 @@ +# *-*- Mode: Python -*-* By the way JSON does not seem to support comments

Re: [Qemu-devel] [PATCH 14/22] qapi: add query-version QMP command

2011-03-07 Thread Anthony Liguori
On 03/07/2011 07:35 AM, Stefan Hajnoczi wrote: On Mon, Mar 7, 2011 at 1:22 AM, Anthony Liguorialigu...@us.ibm.com wrote: diff --git a/qmp-schema.json b/qmp-schema.json index e69de29..b343f5e 100644 --- a/qmp-schema.json +++ b/qmp-schema.json @@ -0,0 +1,38 @@ +# *-*- Mode: Python -*-*

[Qemu-devel] [PATCH 14/22] qapi: add query-version QMP command

2011-03-06 Thread Anthony Liguori
This is used internally by QMP. It's also a pretty good example of a typical command conversion. Signed-off-by: Anthony Liguori aligu...@us.ibm.com diff --git a/Makefile.objs b/Makefile.objs index 5dae800..e1a2756 100644 --- a/Makefile.objs +++ b/Makefile.objs @@ -103,7 +103,7 @@ common-obj-y