Re: [Qemu-devel] [PATCH 15/55] ide/atapi: Clean up misleading name in cmd_start_stop_unit()

2011-07-26 Thread Christoph Hellwig
On Wed, Jul 20, 2011 at 06:23:49PM +0200, Markus Armbruster wrote: eject is misleading; it means eject when start is clear, but load when start is set. Rename to loej, because that's how MMC-5 calls it, in section 6.40. Just as clear as the bdrv_eject name :) Looks fine anyway, Reviewed-by:

[Qemu-devel] [PATCH 15/55] ide/atapi: Clean up misleading name in cmd_start_stop_unit()

2011-07-20 Thread Markus Armbruster
eject is misleading; it means eject when start is clear, but load when start is set. Rename to loej, because that's how MMC-5 calls it, in section 6.40. Signed-off-by: Markus Armbruster arm...@redhat.com --- hw/ide/atapi.c |8 1 files changed, 4 insertions(+), 4 deletions(-) diff