Re: [Qemu-devel] [PATCH 16/18] console: stop using DisplayState in gfx hardware emulation

2013-04-20 Thread Jan Kiszka
On 2013-04-16 09:42, Gerd Hoffmann wrote: > On 04/10/13 10:31, Jan Kiszka wrote: >> On 2013-04-03 13:50, Gerd Hoffmann wrote: >>> Hi, >>> > No, it is not, and yes, this is where the inconsistency comes > from. We read wred+wgreen+wblue directly from the surface > whereas depth is c

Re: [Qemu-devel] [PATCH 16/18] console: stop using DisplayState in gfx hardware emulation

2013-04-16 Thread Gerd Hoffmann
On 04/10/13 10:31, Jan Kiszka wrote: > On 2013-04-03 13:50, Gerd Hoffmann wrote: >> Hi, >> No, it is not, and yes, this is where the inconsistency comes from. We read wred+wgreen+wblue directly from the surface whereas depth is cached in the vmware vga state struct. Patch

Re: [Qemu-devel] [PATCH 16/18] console: stop using DisplayState in gfx hardware emulation

2013-04-10 Thread Jan Kiszka
On 2013-04-03 13:50, Gerd Hoffmann wrote: > Hi, > >>> No, it is not, and yes, this is where the inconsistency comes >>> from. We read wred+wgreen+wblue directly from the surface >>> whereas depth is cached in the vmware vga state struct. Patch >>> attached. Not fully tested yet. >> >> Unfo

Re: [Qemu-devel] [PATCH 16/18] console: stop using DisplayState in gfx hardware emulation

2013-04-03 Thread Gerd Hoffmann
Hi, >> No, it is not, and yes, this is where the inconsistency comes >> from. We read wred+wgreen+wblue directly from the surface >> whereas depth is cached in the vmware vga state struct. Patch >> attached. Not fully tested yet. > > Unfortunately, this doesn't change the picture (except

Re: [Qemu-devel] [PATCH 16/18] console: stop using DisplayState in gfx hardware emulation

2013-03-26 Thread Jan Kiszka
On 2013-03-25 21:30, Gerd Hoffmann wrote: > On 03/25/13 14:56, Igor Mitsyanko wrote: >> On 03/25/2013 02:37 PM, Gerd Hoffmann wrote: >>> Hi, [5425.580115] displaysurface_create_from surface=0x7ff315d3df40, > 800x600, bpp 16, bswap 0 [5425.580257] displaysurface_free > sur

Re: [Qemu-devel] [PATCH 16/18] console: stop using DisplayState in gfx hardware emulation

2013-03-25 Thread BALATON Zoltan
On Mon, 25 Mar 2013, Gerd Hoffmann wrote: No, it is not, and yes, this is where the inconsistency comes from. We read wred+wgreen+wblue directly from the surface whereas depth is cached in the vmware vga state struct. Patch attached. Not fully tested yet. Tried that before and it didn't work

Re: [Qemu-devel] [PATCH 16/18] console: stop using DisplayState in gfx hardware emulation

2013-03-25 Thread Gerd Hoffmann
On 03/25/13 14:56, Igor Mitsyanko wrote: > On 03/25/2013 02:37 PM, Gerd Hoffmann wrote: >> >>>Hi, >>> >>> [5425.580115] displaysurface_create_from surface=0x7ff315d3df40, 800x600, bpp 16, bswap 0 [5425.580257] displaysurface_free surface=0x7ff3158c33b0 >>> >>> This is vga=0x314

Re: [Qemu-devel] [PATCH 16/18] console: stop using DisplayState in gfx hardware emulation

2013-03-25 Thread Igor Mitsyanko
On 03/25/2013 02:37 PM, Gerd Hoffmann wrote: > >>Hi, >> >> [5425.580115] displaysurface_create_from surface=0x7ff315d3df40, >>> 800x600, bpp 16, bswap 0 [5425.580257] displaysurface_free >>> surface=0x7ff3158c33b0 >>> >> >> This is vga=0x314 >> >> Looks like we have some funky interaction betw

Re: [Qemu-devel] [PATCH 16/18] console: stop using DisplayState in gfx hardware emulation

2013-03-25 Thread Gerd Hoffmann
Hi, > [5425.580115] displaysurface_create_from surface=0x7ff315d3df40, > 800x600, bpp 16, bswap 0 [5425.580257] displaysurface_free > surface=0x7ff3158c33b0 This is vga=0x314 Looks like we have some funky interaction between vga and vmware. I'll go dig. Meanwhile you can try vga=0x315 (800x6

Re: [Qemu-devel] [PATCH 16/18] console: stop using DisplayState in gfx hardware emulation

2013-03-25 Thread Jan Kiszka
On 2013-03-25 10:55, Jan Kiszka wrote: > On 2013-03-25 10:48, Gerd Hoffmann wrote: >> On 03/25/13 10:32, Jan Kiszka wrote: >>> On 2013-03-25 10:10, Gerd Hoffmann wrote: On 03/25/13 09:40, Jan Kiszka wrote: > On 2013-03-25 09:39, Gerd Hoffmann wrote: >> Hi, >> Any hints in

Re: [Qemu-devel] [PATCH 16/18] console: stop using DisplayState in gfx hardware emulation

2013-03-25 Thread Jan Kiszka
On 2013-03-25 10:48, Gerd Hoffmann wrote: > On 03/25/13 10:32, Jan Kiszka wrote: >> On 2013-03-25 10:10, Gerd Hoffmann wrote: >>> On 03/25/13 09:40, Jan Kiszka wrote: On 2013-03-25 09:39, Gerd Hoffmann wrote: > Hi, > >>> Any hints in the X server log? >> >> "vmwlegacy(0): W

Re: [Qemu-devel] [PATCH 16/18] console: stop using DisplayState in gfx hardware emulation

2013-03-25 Thread Gerd Hoffmann
On 03/25/13 10:32, Jan Kiszka wrote: > On 2013-03-25 10:10, Gerd Hoffmann wrote: >> On 03/25/13 09:40, Jan Kiszka wrote: >>> On 2013-03-25 09:39, Gerd Hoffmann wrote: Hi, >> Any hints in the X server log? > > "vmwlegacy(0): Weight given (565) is inconsistent with the > d

Re: [Qemu-devel] [PATCH 16/18] console: stop using DisplayState in gfx hardware emulation

2013-03-25 Thread Jan Kiszka
On 2013-03-25 10:10, Gerd Hoffmann wrote: > On 03/25/13 09:40, Jan Kiszka wrote: >> On 2013-03-25 09:39, Gerd Hoffmann wrote: >>> Hi, >>> > Any hints in the X server log? "vmwlegacy(0): Weight given (565) is inconsistent with the depth (24)" >>> >>> Weight hints depth 16 indeed

Re: [Qemu-devel] [PATCH 16/18] console: stop using DisplayState in gfx hardware emulation

2013-03-25 Thread Gerd Hoffmann
On 03/25/13 09:40, Jan Kiszka wrote: > On 2013-03-25 09:39, Gerd Hoffmann wrote: >> Hi, >> Any hints in the X server log? >>> >>> "vmwlegacy(0): Weight given (565) is inconsistent with the depth >>> (24)" >> >> Weight hints depth 16 indeed. What depth used the server to run at? >> 16 or 24?

Re: [Qemu-devel] [PATCH 16/18] console: stop using DisplayState in gfx hardware emulation

2013-03-25 Thread Jan Kiszka
On 2013-03-25 09:39, Gerd Hoffmann wrote: > Hi, > >>> Any hints in the X server log? >> >> "vmwlegacy(0): Weight given (565) is inconsistent with the depth >> (24)" > > Weight hints depth 16 indeed. What depth used the server to run at? > 16 or 24? 24 signature.asc Description: OpenPGP dig

Re: [Qemu-devel] [PATCH 16/18] console: stop using DisplayState in gfx hardware emulation

2013-03-25 Thread Gerd Hoffmann
Hi, >> Any hints in the X server log? > > "vmwlegacy(0): Weight given (565) is inconsistent with the depth > (24)" Weight hints depth 16 indeed. What depth used the server to run at? 16 or 24? cheers, Gerd

Re: [Qemu-devel] [PATCH 16/18] console: stop using DisplayState in gfx hardware emulation

2013-03-25 Thread Jan Kiszka
On 2013-03-25 09:21, Gerd Hoffmann wrote: > On 03/25/13 08:59, Jan Kiszka wrote: >> On 2013-03-25 08:55, Gerd Hoffmann wrote: >>> On 03/25/13 08:50, Jan Kiszka wrote: On 2013-03-12 11:32, Gerd Hoffmann wrote: > Use QemuConsole instead. Updates interfaces in console.[ch] > and adapts g

Re: [Qemu-devel] [PATCH 16/18] console: stop using DisplayState in gfx hardware emulation

2013-03-25 Thread Gerd Hoffmann
On 03/25/13 08:59, Jan Kiszka wrote: > On 2013-03-25 08:55, Gerd Hoffmann wrote: >> On 03/25/13 08:50, Jan Kiszka wrote: >>> On 2013-03-12 11:32, Gerd Hoffmann wrote: Use QemuConsole instead. Updates interfaces in console.[ch] and adapts gfx hardware emulation code. >>> >>> Breaks vmwar

Re: [Qemu-devel] [PATCH 16/18] console: stop using DisplayState in gfx hardware emulation

2013-03-25 Thread Jan Kiszka
On 2013-03-25 08:55, Gerd Hoffmann wrote: > On 03/25/13 08:50, Jan Kiszka wrote: >> On 2013-03-12 11:32, Gerd Hoffmann wrote: >>> Use QemuConsole instead. Updates interfaces in console.[ch] and >>> adapts gfx hardware emulation code. >> >> Breaks vmware-vga, the X server no longer starts up. >> >>

Re: [Qemu-devel] [PATCH 16/18] console: stop using DisplayState in gfx hardware emulation

2013-03-25 Thread Gerd Hoffmann
On 03/25/13 08:50, Jan Kiszka wrote: > On 2013-03-12 11:32, Gerd Hoffmann wrote: >> Use QemuConsole instead. Updates interfaces in console.[ch] and >> adapts gfx hardware emulation code. > > Breaks vmware-vga, the X server no longer starts up. > > I do not spot any obvious typo etc. in the conve

Re: [Qemu-devel] [PATCH 16/18] console: stop using DisplayState in gfx hardware emulation

2013-03-25 Thread Jan Kiszka
On 2013-03-12 11:32, Gerd Hoffmann wrote: > Use QemuConsole instead. Updates interfaces in console.[ch] and adapts > gfx hardware emulation code. Breaks vmware-vga, the X server no longer starts up. I do not spot any obvious typo etc. in the conversion, so I suspect, some values returned by the