Re: [Qemu-devel] [PATCH 16/55] ide/atapi: Track tray open/close state

2011-07-26 Thread Christoph Hellwig
On Wed, Jul 20, 2011 at 06:23:50PM +0200, Markus Armbruster wrote: We already track it in BlockDriverState since commit 4be9762a. As discussed in that commit's message, we should track it in the device device models instead, because it's device state. Looks good, Reviewed-by: Christoph

[Qemu-devel] [PATCH 16/55] ide/atapi: Track tray open/close state

2011-07-20 Thread Markus Armbruster
We already track it in BlockDriverState since commit 4be9762a. As discussed in that commit's message, we should track it in the device device models instead, because it's device state. Signed-off-by: Markus Armbruster arm...@redhat.com --- hw/ide/atapi.c|4 hw/ide/internal.h |1