Re: [Qemu-devel] [PATCH 17/19] uninorth: create new uninorth device

2018-04-25 Thread David Gibson
On Wed, Apr 25, 2018 at 07:58:31AM +0100, Mark Cave-Ayland wrote: > On 25/04/18 07:34, David Gibson wrote: > > > On Wed, Apr 25, 2018 at 07:06:03AM +0100, Mark Cave-Ayland wrote: > > > On 06/04/18 06:33, Mark Cave-Ayland wrote: > > > > > > > On 25/03/18 22:11, Mark Cave-Ayland wrote: > > > > > >

Re: [Qemu-devel] [PATCH 17/19] uninorth: create new uninorth device

2018-04-25 Thread Philippe Mathieu-Daudé
On 04/25/2018 03:58 AM, Mark Cave-Ayland wrote: > On 25/04/18 07:34, David Gibson wrote: >> On Wed, Apr 25, 2018 at 07:06:03AM +0100, Mark Cave-Ayland wrote: >>> On 06/04/18 06:33, Mark Cave-Ayland wrote: On 25/03/18 22:11, Mark Cave-Ayland wrote: > Just to follow up on this, I spent

Re: [Qemu-devel] [PATCH 17/19] uninorth: create new uninorth device

2018-04-25 Thread Mark Cave-Ayland
On 25/04/18 07:34, David Gibson wrote: On Wed, Apr 25, 2018 at 07:06:03AM +0100, Mark Cave-Ayland wrote: On 06/04/18 06:33, Mark Cave-Ayland wrote: On 25/03/18 22:11, Mark Cave-Ayland wrote: Just to follow up on this, I spent a bit looking at what this register is trying to do and from the

Re: [Qemu-devel] [PATCH 17/19] uninorth: create new uninorth device

2018-04-24 Thread David Gibson
On Wed, Apr 25, 2018 at 07:06:03AM +0100, Mark Cave-Ayland wrote: > On 06/04/18 06:33, Mark Cave-Ayland wrote: > > > On 25/03/18 22:11, Mark Cave-Ayland wrote: > > > > > Just to follow up on this, I spent a bit looking at what this > > > register is trying to do and from the Darwin source I can s

Re: [Qemu-devel] [PATCH 17/19] uninorth: create new uninorth device

2018-04-24 Thread Mark Cave-Ayland
On 06/04/18 06:33, Mark Cave-Ayland wrote: On 25/03/18 22:11, Mark Cave-Ayland wrote: Just to follow up on this, I spent a bit looking at what this register is trying to do and from the Darwin source I can see that in fact it is simply a hard-wired hardware register which should return the r

Re: [Qemu-devel] [PATCH 17/19] uninorth: create new uninorth device

2018-04-05 Thread Mark Cave-Ayland
On 25/03/18 22:11, Mark Cave-Ayland wrote: Just to follow up on this, I spent a bit looking at what this register is trying to do and from the Darwin source I can see that in fact it is simply a hard-wired hardware register which should return the revision of the UniNorth hardware. So in fac

Re: [Qemu-devel] [PATCH 17/19] uninorth: create new uninorth device

2018-03-25 Thread Mark Cave-Ayland
On 22/03/18 09:00, Philippe Mathieu-Daudé wrote: Hi Mark, On 03/21/2018 12:29 AM, David Gibson wrote: On Tue, Mar 06, 2018 at 08:31:01PM +, Mark Cave-Ayland wrote: Commit 4e46dcdbd3 "PPC: Newworld: Add uninorth token register" added a TODO which was to convert the uninorth registers hack

Re: [Qemu-devel] [PATCH 17/19] uninorth: create new uninorth device

2018-03-22 Thread Philippe Mathieu-Daudé
Hi Mark, On 03/21/2018 12:29 AM, David Gibson wrote: > On Tue, Mar 06, 2018 at 08:31:01PM +, Mark Cave-Ayland wrote: >> Commit 4e46dcdbd3 "PPC: Newworld: Add uninorth token register" added a TODO >> which was to convert the uninorth registers hack to a proper device. Move >> these registers to

Re: [Qemu-devel] [PATCH 17/19] uninorth: create new uninorth device

2018-03-20 Thread David Gibson
On Tue, Mar 06, 2018 at 08:31:01PM +, Mark Cave-Ayland wrote: > Commit 4e46dcdbd3 "PPC: Newworld: Add uninorth token register" added a TODO > which was to convert the uninorth registers hack to a proper device. Move > these registers to a new uninorth device, removing the old hacks from > mac_n

[Qemu-devel] [PATCH 17/19] uninorth: create new uninorth device

2018-03-06 Thread Mark Cave-Ayland
Commit 4e46dcdbd3 "PPC: Newworld: Add uninorth token register" added a TODO which was to convert the uninorth registers hack to a proper device. Move these registers to a new uninorth device, removing the old hacks from mac_newworld.c. Signed-off-by: Mark Cave-Ayland --- hw/pci-host/trace-events