Re: [Qemu-devel] [PATCH 17/20] target/arm: Implement SG instruction

2017-10-05 Thread Richard Henderson
On 10/05/2017 02:55 PM, Peter Maydell wrote: > Oops. I missed this in my testing because it happens that the > two halves of an SG instruction are the same value :-) Hah. I didn't notice that either. r~

Re: [Qemu-devel] [PATCH 17/20] target/arm: Implement SG instruction

2017-10-05 Thread Peter Maydell
On 5 October 2017 at 19:50, Richard Henderson wrote: > On 09/22/2017 11:00 AM, Peter Maydell wrote: >> Implement the SG instruction, which we emulate 'by hand' in the >> exception handling code path. >> >> Signed-off-by: Peter Maydell >> --- >> target/arm/helper.c | 129 >> +

Re: [Qemu-devel] [PATCH 17/20] target/arm: Implement SG instruction

2017-10-05 Thread Richard Henderson
On 09/22/2017 11:00 AM, Peter Maydell wrote: > Implement the SG instruction, which we emulate 'by hand' in the > exception handling code path. > > Signed-off-by: Peter Maydell > --- > target/arm/helper.c | 129 > ++-- > 1 file changed, 124 inserti

[Qemu-devel] [PATCH 17/20] target/arm: Implement SG instruction

2017-09-22 Thread Peter Maydell
Implement the SG instruction, which we emulate 'by hand' in the exception handling code path. Signed-off-by: Peter Maydell --- target/arm/helper.c | 129 ++-- 1 file changed, 124 insertions(+), 5 deletions(-) diff --git a/target/arm/helper.c b/tar