Re: [Qemu-devel] [PATCH 17/25] audio: remove gcc specific audio_MIN, audio_MAX

2015-08-20 Thread Peter Maydell
On 19 August 2015 at 19:17, Gerd Hoffmann wrote: > On Do, 2015-08-06 at 20:28 +0200, Kővágó, Zoltán wrote: >> Currently the gcc specific version only evaluates the arguments once, >> while the generic version evaluates one argument twice, which can cause >> debugging headaches when an argument has

Re: [Qemu-devel] [PATCH 17/25] audio: remove gcc specific audio_MIN, audio_MAX

2015-08-20 Thread Marc-André Lureau
Hi On Thu, Aug 6, 2015 at 8:28 PM, Kővágó, Zoltán wrote: > Currently the gcc specific version only evaluates the arguments once, > while the generic version evaluates one argument twice, which can cause > debugging headaches when an argument has a side effect. This patch at > least provides cons

Re: [Qemu-devel] [PATCH 17/25] audio: remove gcc specific audio_MIN, audio_MAX

2015-08-19 Thread Gerd Hoffmann
On Do, 2015-08-06 at 20:28 +0200, Kővágó, Zoltán wrote: > Currently the gcc specific version only evaluates the arguments once, > while the generic version evaluates one argument twice, which can cause > debugging headaches when an argument has a side effect. The answer to that is "don't do that".

[Qemu-devel] [PATCH 17/25] audio: remove gcc specific audio_MIN, audio_MAX

2015-08-06 Thread Kővágó, Zoltán
Currently the gcc specific version only evaluates the arguments once, while the generic version evaluates one argument twice, which can cause debugging headaches when an argument has a side effect. This patch at least provides consistent behavior between compilers. Signed-off-by: Kővágó, Zoltán