Re: [Qemu-devel] [PATCH 17/34] qcow2: Leave s unchanged on qcow2_update_options() failure

2015-05-13 Thread Max Reitz
On 08.05.2015 19:21, Kevin Wolf wrote: On return, either all new options should be applied to BDRVQcowState (on success), or all of the old setting should be preserved (on failure). Signed-off-by: Kevin Wolf kw...@redhat.com --- block/qcow2.c | 52

Re: [Qemu-devel] [PATCH 17/34] qcow2: Leave s unchanged on qcow2_update_options() failure

2015-05-12 Thread Eric Blake
On 05/08/2015 11:21 AM, Kevin Wolf wrote: On return, either all new options should be applied to BDRVQcowState (on success), or all of the old setting should be preserved (on failure). s/setting/settings/ Signed-off-by: Kevin Wolf kw...@redhat.com --- block/qcow2.c | 52

[Qemu-devel] [PATCH 17/34] qcow2: Leave s unchanged on qcow2_update_options() failure

2015-05-08 Thread Kevin Wolf
On return, either all new options should be applied to BDRVQcowState (on success), or all of the old setting should be preserved (on failure). Signed-off-by: Kevin Wolf kw...@redhat.com --- block/qcow2.c | 52 1 file changed, 32 insertions(+),