Re: [Qemu-devel] [PATCH 18/18] blockdev: 'blockdev-add' QMP command

2013-08-30 Thread Wenchao Xia
于 2013-7-23 21:03, Kevin Wolf 写道: > Signed-off-by: Kevin Wolf > --- > blockdev.c | 45 + > qapi-schema.json | 293 > +++ > qmp-commands.hx | 26 + > 3 files changed, 364 insertions(+) > > diff --git a/blockdev.c b/bloc

Re: [Qemu-devel] [PATCH 18/18] blockdev: 'blockdev-add' QMP command

2013-07-31 Thread Kevin Wolf
Am 30.07.2013 um 19:44 hat Luiz Capitulino geschrieben: > On Fri, 26 Jul 2013 20:14:06 +0200 > Kevin Wolf wrote: > > > Am 26.07.2013 um 19:45 hat Eric Blake geschrieben: > > > Overall, I like where this is headed, but I'm not quite sure it is ready > > > for commit as-is; looking forward to v2.

Re: [Qemu-devel] [PATCH 18/18] blockdev: 'blockdev-add' QMP command

2013-07-30 Thread Luiz Capitulino
On Fri, 26 Jul 2013 20:14:06 +0200 Kevin Wolf wrote: > Am 26.07.2013 um 19:45 hat Eric Blake geschrieben: > > Overall, I like where this is headed, but I'm not quite sure it is ready > > for commit as-is; looking forward to v2. Given my positive review on > > the rest of the series, I think you

Re: [Qemu-devel] [PATCH 18/18] blockdev: 'blockdev-add' QMP command

2013-07-26 Thread Kevin Wolf
Am 26.07.2013 um 19:45 hat Eric Blake geschrieben: > Overall, I like where this is headed, but I'm not quite sure it is ready > for commit as-is; looking forward to v2. Given my positive review on > the rest of the series, I think you could get away with a pull request > on the front half of the s

Re: [Qemu-devel] [PATCH 18/18] blockdev: 'blockdev-add' QMP command

2013-07-26 Thread Eric Blake
On 07/23/2013 07:03 AM, Kevin Wolf wrote: Is it worth a snippet of QMP wire code in the commit message, so that someone reading 'git log' can more easily spot the impact of this patch? > Signed-off-by: Kevin Wolf > --- > blockdev.c | 45 + > qapi-schema.json | 293 >

[Qemu-devel] [PATCH 18/18] blockdev: 'blockdev-add' QMP command

2013-07-23 Thread Kevin Wolf
Signed-off-by: Kevin Wolf --- blockdev.c | 45 + qapi-schema.json | 293 +++ qmp-commands.hx | 26 + 3 files changed, 364 insertions(+) diff --git a/blockdev.c b/blockdev.c index ef55b1a..214173b 100644 --- a/blockdev.c +++