Re: [Qemu-devel] [PATCH 18/55] scsi-disk: Reject CD-specific SCSI commands to disks

2011-07-29 Thread Markus Armbruster
Markus Armbruster arm...@redhat.com writes: Christoph Hellwig h...@lst.de writes: On Wed, Jul 20, 2011 at 06:23:52PM +0200, Markus Armbruster wrote: Use a table to declare which drive kinds accept each command. Limit READ_CAPACITY, READ_TOC, GET_CONFIGURATION to SCSI_CD, as per SPC-4.

Re: [Qemu-devel] [PATCH 18/55] scsi-disk: Reject CD-specific SCSI commands to disks

2011-07-26 Thread Christoph Hellwig
On Wed, Jul 20, 2011 at 06:23:52PM +0200, Markus Armbruster wrote: Use a table to declare which drive kinds accept each command. Limit READ_CAPACITY, READ_TOC, GET_CONFIGURATION to SCSI_CD, as per SPC-4. READ CAPACITY is defined in SBC, and absolutely required for proper operation with

Re: [Qemu-devel] [PATCH 18/55] scsi-disk: Reject CD-specific SCSI commands to disks

2011-07-26 Thread Markus Armbruster
Christoph Hellwig h...@lst.de writes: On Wed, Jul 20, 2011 at 06:23:52PM +0200, Markus Armbruster wrote: Use a table to declare which drive kinds accept each command. Limit READ_CAPACITY, READ_TOC, GET_CONFIGURATION to SCSI_CD, as per SPC-4. READ CAPACITY is defined in SBC, and absolutely

[Qemu-devel] [PATCH 18/55] scsi-disk: Reject CD-specific SCSI commands to disks

2011-07-20 Thread Markus Armbruster
Use a table to declare which drive kinds accept each command. Limit READ_CAPACITY, READ_TOC, GET_CONFIGURATION to SCSI_CD, as per SPC-4. It would be nice to have handler functions in the table, like commit e1a064f9 did for ATAPI. Left for another day. Signed-off-by: Markus Armbruster