Re: [Qemu-devel] [PATCH 19/23] pc: move global memory map out of pc_init1() and into its callers

On 07/25/2011 11:02 PM, Anthony Liguori wrote: On 07/25/2011 09:03 AM, Avi Kivity wrote: Signed-off-by: Avi Kivitya...@redhat.com What's the rationale here? Removing globals and making dependencies explicit. -- error compiling committee.c: too many arguments to function

[Qemu-devel] [PATCH 19/23] pc: move global memory map out of pc_init1() and into its callers

Signed-off-by: Avi Kivity a...@redhat.com --- hw/pc_piix.c | 15 --- 1 files changed, 8 insertions(+), 7 deletions(-) diff --git a/hw/pc_piix.c b/hw/pc_piix.c index d83854c..f2d0476 100644 --- a/hw/pc_piix.c +++ b/hw/pc_piix.c @@ -68,7 +68,8 @@ static void ioapic_init(IsaIrqState

Re: [Qemu-devel] [PATCH 19/23] pc: move global memory map out of pc_init1() and into its callers

On 07/25/2011 09:03 AM, Avi Kivity wrote: Signed-off-by: Avi Kivitya...@redhat.com What's the rationale here? Regards, Anthony Liguori --- hw/pc_piix.c | 15 --- 1 files changed, 8 insertions(+), 7 deletions(-) diff --git a/hw/pc_piix.c b/hw/pc_piix.c index