Re: [Qemu-devel] [PATCH 19/28] target/riscv: Replace gen_branch() with trans_branch()

2018-10-13 Thread Richard Henderson
On 10/12/18 10:30 AM, Bastian Koppelmann wrote: > +static bool trans_branch(DisasContext *ctx, arg_branch *a, TCGCond cond) I think you should still call it gen_branch. Reserve the trans_ prefix for things called from the decoder. Otherwise, Reviewed-by: Richard Henderson r~

[Qemu-devel] [PATCH 19/28] target/riscv: Replace gen_branch() with trans_branch()

2018-10-12 Thread Bastian Koppelmann
The latter utilizes argument-sets of decodetree such that no manual decoding is necessary as in gen_branch(). Signed-off-by: Bastian Koppelmann Signed-off-by: Peer Adelt --- target/riscv/insn_trans/trans_rvi.inc.c | 56 + target/riscv/translate.c| 47