Re: [Qemu-devel] [PATCH 2/2] Add PIIX4 properties to control PM system states.

2012-05-23 Thread Anthony Liguori
On 05/20/2012 04:02 AM, Gleb Natapov wrote: This patch adds two things. First it allows QEMU to distinguish between regular powerdown and S4 powerdown. Later separate QMP notification will be added for S4 powerdown. Second it allows S3/S4 states to be disabled from QEMU command line. Some guests

Re: [Qemu-devel] [PATCH 2/2] Add PIIX4 properties to control PM system states.

2012-05-23 Thread Gleb Natapov
On Wed, May 23, 2012 at 08:27:01AM -0500, Anthony Liguori wrote: On 05/20/2012 04:02 AM, Gleb Natapov wrote: This patch adds two things. First it allows QEMU to distinguish between regular powerdown and S4 powerdown. Later separate QMP notification will be added for S4 powerdown. Second it

Re: [Qemu-devel] [PATCH 2/2] Add PIIX4 properties to control PM system states.

2012-05-23 Thread Anthony Liguori
On 05/23/2012 08:34 AM, Gleb Natapov wrote: On Wed, May 23, 2012 at 08:27:01AM -0500, Anthony Liguori wrote: On 05/20/2012 04:02 AM, Gleb Natapov wrote: This patch adds two things. First it allows QEMU to distinguish between regular powerdown and S4 powerdown. Later separate QMP notification

Re: [Qemu-devel] [PATCH 2/2] Add PIIX4 properties to control PM system states.

2012-05-23 Thread Andreas Färber
Am 23.05.2012 15:27, schrieb Anthony Liguori: On 05/20/2012 04:02 AM, Gleb Natapov wrote: This patch adds two things. First it allows QEMU to distinguish between regular powerdown and S4 powerdown. Later separate QMP notification will be added for S4 powerdown. Second it allows S3/S4 states to

Re: [Qemu-devel] [PATCH 2/2] Add PIIX4 properties to control PM system states.

2012-05-23 Thread Paolo Bonzini
Il 23/05/2012 16:34, Andreas Färber ha scritto: I see nothing wrong in principle here except that you should use a PTR property to pass the fw_cfg object to the ACPI PM device. Paolo was on a quest to eliminate the PTR properties so I don't think we should advocate adding any more.

Re: [Qemu-devel] [PATCH 2/2] Add PIIX4 properties to control PM system states.

2012-05-23 Thread Anthony Liguori
On 05/23/2012 09:42 AM, Paolo Bonzini wrote: Il 23/05/2012 16:34, Andreas Färber ha scritto: I see nothing wrong in principle here except that you should use a PTR property to pass the fw_cfg object to the ACPI PM device. Paolo was on a quest to eliminate the PTR properties so I don't think

Re: [Qemu-devel] [PATCH 2/2] Add PIIX4 properties to control PM system states.

2012-05-23 Thread Gleb Natapov
On Wed, May 23, 2012 at 10:11:08AM -0500, Anthony Liguori wrote: On 05/23/2012 09:42 AM, Paolo Bonzini wrote: Il 23/05/2012 16:34, Andreas Färber ha scritto: I see nothing wrong in principle here except that you should use a PTR property to pass the fw_cfg object to the ACPI PM device.

[Qemu-devel] [PATCH 2/2] Add PIIX4 properties to control PM system states.

2012-05-20 Thread Gleb Natapov
This patch adds two things. First it allows QEMU to distinguish between regular powerdown and S4 powerdown. Later separate QMP notification will be added for S4 powerdown. Second it allows S3/S4 states to be disabled from QEMU command line. Some guests known to be broken with regards to power

[Qemu-devel] [PATCH 2/2] Add PIIX4 properties to control PM system states.

2012-05-14 Thread Gleb Natapov
This patch adds two things. First it allows QEMU to distinguish between regular powerdown and S4 powerdown. Later separate QMP notification will be added for S4 powerdown. Second it allows S3/S4 states to be disabled from QEMU command line. Some guests known to be broken with regards to power