Re: [Qemu-devel] [PATCH 2/2] Add file-posix-dynamic-auto-read-only feature

2019-03-29 Thread Kevin Wolf
Am 29.03.2019 um 14:14 hat Markus Armbruster geschrieben: > Markus Armbruster writes: > > > Kevin Wolf writes: > > > >> auto-read-only=on changed its behaviour in file-posix for the 4.0 > >> release. > > > > Commit hash, please. > > I guess it's commit 23dece19da4 "file-posix: Make auto-read-on

Re: [Qemu-devel] [PATCH 2/2] Add file-posix-dynamic-auto-read-only feature

2019-03-29 Thread Markus Armbruster
Markus Armbruster writes: > Markus Armbruster writes: > >> Markus Armbruster writes: >> >>> Kevin Wolf writes: >>> auto-read-only=on changed its behaviour in file-posix for the 4.0 release. >>> >>> Commit hash, please. >> >> I guess it's commit 23dece19da4 "file-posix: Make auto-read

Re: [Qemu-devel] [PATCH 2/2] Add file-posix-dynamic-auto-read-only feature

2019-03-29 Thread Kevin Wolf
Am 29.03.2019 um 17:19 hat Markus Armbruster geschrieben: > Markus Armbruster writes: > > > Markus Armbruster writes: > > > >> Markus Armbruster writes: > >> > >>> Kevin Wolf writes: > >>> > auto-read-only=on changed its behaviour in file-posix for the 4.0 > release. > >>> > >>> Comm

Re: [Qemu-devel] [PATCH 2/2] Add file-posix-dynamic-auto-read-only feature

2019-03-29 Thread Markus Armbruster
Markus Armbruster writes: > Markus Armbruster writes: > >> Kevin Wolf writes: >> >>> auto-read-only=on changed its behaviour in file-posix for the 4.0 >>> release. >> >> Commit hash, please. > > I guess it's commit 23dece19da4 "file-posix: Make auto-read-only > dynamic". > >>> This cha

Re: [Qemu-devel] [PATCH 2/2] Add file-posix-dynamic-auto-read-only feature

2019-03-29 Thread Markus Armbruster
Peter Krempa writes: > On Fri, Mar 29, 2019 at 14:05:46 +0100, Markus Armbruster wrote: >> Peter Krempa writes: >> >> [...] >> > Whether there is a static entry in the QMP schema (which feels wrong >> > btw as it does not actually expose something which is regarding the >> > interaction with QM

Re: [Qemu-devel] [PATCH 2/2] Add file-posix-dynamic-auto-read-only feature

2019-03-29 Thread Peter Krempa
On Fri, Mar 29, 2019 at 14:05:46 +0100, Markus Armbruster wrote: > Peter Krempa writes: > > [...] > > Whether there is a static entry in the QMP schema (which feels wrong > > btw as it does not actually expose something which is regarding the > > interaction with QMP) or something like this, we n

Re: [Qemu-devel] [PATCH 2/2] Add file-posix-dynamic-auto-read-only feature

2019-03-29 Thread Markus Armbruster
Markus Armbruster writes: > Kevin Wolf writes: > >> auto-read-only=on changed its behaviour in file-posix for the 4.0 >> release. > > Commit hash, please. I guess it's commit 23dece19da4 "file-posix: Make auto-read-only dynamic". >> This change cannot be detected through the usual mec

Re: [Qemu-devel] [PATCH 2/2] Add file-posix-dynamic-auto-read-only feature

2019-03-29 Thread Markus Armbruster
Peter Krempa writes: [...] > Whether there is a static entry in the QMP schema (which feels wrong > btw as it does not actually expose something which is regarding the > interaction with QMP) or something like this, we need it yesterday. I > don't want to add version checks any more. I do unders

Re: [Qemu-devel] [PATCH 2/2] Add file-posix-dynamic-auto-read-only feature

2019-03-29 Thread Peter Krempa
On Fri, Mar 29, 2019 at 10:57:55 +0100, Markus Armbruster wrote: > Kevin Wolf writes: > > > auto-read-only=on changed its behaviour in file-posix for the 4.0 > > release. > > Commit hash, please. > > > This change cannot be detected through the usual mechanisms > > like schema introspe

Re: [Qemu-devel] [PATCH 2/2] Add file-posix-dynamic-auto-read-only feature

2019-03-29 Thread Markus Armbruster
Kevin Wolf writes: > auto-read-only=on changed its behaviour in file-posix for the 4.0 > release. Commit hash, please. > This change cannot be detected through the usual mechanisms > like schema introspection. Add a new feature to query-qemu-features to > allow libvirt to detect the pr

Re: [Qemu-devel] [PATCH 2/2] Add file-posix-dynamic-auto-read-only feature

2019-03-29 Thread Peter Krempa
On Fri, Mar 29, 2019 at 08:52:13 +0100, Kevin Wolf wrote: > Am 28.03.2019 um 19:45 hat Eric Blake geschrieben: > > On 3/28/19 1:28 PM, Kevin Wolf wrote: > > > auto-read-only=on changed its behaviour in file-posix for the 4.0 > > > release. This change cannot be detected through the usual mechanisms

Re: [Qemu-devel] [PATCH 2/2] Add file-posix-dynamic-auto-read-only feature

2019-03-29 Thread Kevin Wolf
Am 28.03.2019 um 19:45 hat Eric Blake geschrieben: > On 3/28/19 1:28 PM, Kevin Wolf wrote: > > auto-read-only=on changed its behaviour in file-posix for the 4.0 > > release. This change cannot be detected through the usual mechanisms > > like schema introspection. Add a new feature to query-qemu-fe

Re: [Qemu-devel] [PATCH 2/2] Add file-posix-dynamic-auto-read-only feature

2019-03-28 Thread Eric Blake
On 3/28/19 1:28 PM, Kevin Wolf wrote: > auto-read-only=on changed its behaviour in file-posix for the 4.0 > release. This change cannot be detected through the usual mechanisms > like schema introspection. Add a new feature to query-qemu-features to > allow libvirt to detect the presence of the new

[Qemu-devel] [PATCH 2/2] Add file-posix-dynamic-auto-read-only feature

2019-03-28 Thread Kevin Wolf
auto-read-only=on changed its behaviour in file-posix for the 4.0 release. This change cannot be detected through the usual mechanisms like schema introspection. Add a new feature to query-qemu-features to allow libvirt to detect the presence of the new behaviour. Signed-off-by: Kevin Wolf --- q