Re: [Qemu-devel] [PATCH 2/2] Added monitor commands: 'keyboard_set' and 'info keybaord'

2010-03-31 Thread Shahar Havivi
On Wed, Mar 31, 2010 at 05:10:22PM +0200, Markus Armbruster wrote: > Date: Wed, 31 Mar 2010 17:10:22 +0200 > From: Markus Armbruster > To: Shahar Havivi > Cc: qemu-devel@nongnu.org > Subject: Re: [Qemu-devel] [PATCH 2/2] Added monitor commands: > 'keyboard_set' and

Re: [Qemu-devel] [PATCH 2/2] Added monitor commands: 'keyboard_set' and 'info keybaord'

2010-03-31 Thread Markus Armbruster
Shahar Havivi writes: > On Fri, Mar 26, 2010 at 10:57:58AM +0100, Markus Armbruster wrote: [...] >> Since the index is not a stable identifier of keyboards, and we support >> multiple monitors, you're prone to remove the wrong keyboard. >> >> Monitor#1 Monitor#2 >>

[Qemu-devel] [PATCH 2/2] Added monitor commands: 'keyboard_set' and 'info keybaord'

2010-03-31 Thread Shahar Havivi
Two new monitor commands: adding ability to handle which keyboard qemu will use and to see which keyboard are currently available. $ info keyboard $ keyboard_set Signed-off-by: Shahar Havivi --- console.h |4 ++ input.c | 101 +

Re: [Qemu-devel] [PATCH 2/2] Added monitor commands: 'keyboard_set' and 'info keybaord'

2010-03-27 Thread Shahar Havivi
Fix to Markus comments. --- console.h |6 +++ input.c | 119 ++ monitor.c |8 qemu-monitor.hx | 17 4 files changed, 141 insertions(+), 9 deletions(-) diff --git a/console.h b/console.h index 7d1940

Re: [Qemu-devel] [PATCH 2/2] Added monitor commands: 'keyboard_set' and 'info keybaord'

2010-03-26 Thread Shahar Havivi
On Fri, Mar 26, 2010 at 10:57:58AM +0100, Markus Armbruster wrote: > Date: Fri, 26 Mar 2010 10:57:58 +0100 > From: Markus Armbruster > To: Shahar Havivi > Cc: qemu-devel@nongnu.org > Subject: Re: [Qemu-devel] [PATCH 2/2] Added monitor commands: > 'keyboard_set' and

Re: [Qemu-devel] [PATCH 2/2] Added monitor commands: 'keyboard_set' and 'info keybaord'

2010-03-26 Thread Markus Armbruster
Shahar Havivi writes: > Two new monitor commands: adding ability to handle which keyboard qemu will > use and to see which keyboard are currently available. > > $ info keyboard > $ keyboard_set > > Signed-off-by: Shahar Havivi > --- > console.h |4 ++ > input.c | 104 >

[Qemu-devel] [PATCH 2/2] Added monitor commands: 'keyboard_set' and 'info keybaord'

2010-03-23 Thread Shahar Havivi
Two new monitor commands: adding ability to handle which keyboard qemu will use and to see which keyboard are currently available. $ info keyboard $ keyboard_set Signed-off-by: Shahar Havivi --- console.h |4 ++ input.c | 104 +

Re: [Qemu-devel] [PATCH 2/2] Added monitor commands: 'keyboard_set' and 'info keybaord'

2010-03-21 Thread Luiz Capitulino
On Sat, 20 Mar 2010 00:29:25 +0200 Shahar Havivi wrote: > Fix to Luiz comments. Better to resend the whole series with a 'v2' in it, also I think you'll have to rebase against master because this series conflicts with latest Anthony's series. I have some QError comments below. > > Signed-of

Re: [Qemu-devel] [PATCH 2/2] Added monitor commands: 'keyboard_set' and 'info keybaord'

2010-03-19 Thread Shahar Havivi
Fix to Luiz comments. Signed-off-by: Shahar Havivi --- console.h |4 ++ input.c | 104 +++ monitor.c |8 qemu-monitor.hx | 17 + qerror.c|8 qerror.h|6 +++ 6 files change

Re: [Qemu-devel] [PATCH 2/2] Added monitor commands: 'keyboard_set' and 'info keybaord'

2010-03-19 Thread Shahar Havivi
On Fri, Mar 19, 2010 at 05:22:05PM -0300, Luiz Capitulino wrote: > Date: Fri, 19 Mar 2010 17:22:05 -0300 > From: Luiz Capitulino > To: Shahar Havivi > Cc: Dor Laor , qemu-devel@nongnu.org > Subject: Re: [Qemu-devel] [PATCH 2/2] Added monitor commands: 'keyboard_set' &

Re: [Qemu-devel] [PATCH 2/2] Added monitor commands: 'keyboard_set' and 'info keybaord'

2010-03-19 Thread Luiz Capitulino
On Fri, 19 Mar 2010 12:58:43 +0200 Shahar Havivi wrote: > This new monitor command adding ability to handle which keyboard qemu will use > and to see which keyboard are currently available. > > > Signed-off-by: Shahar Havivi > --- > input.c | 73 > ++

[Qemu-devel] [PATCH 2/2] Added monitor commands: 'keyboard_set' and 'info keybaord'

2010-03-19 Thread Shahar Havivi
This new monitor command adding ability to handle which keyboard qemu will use and to see which keyboard are currently available. Signed-off-by: Shahar Havivi --- input.c | 73 +++ monitor.c |8 ++ qemu-monitor.hx | 1