On 2/19/19 11:20 PM, Wei Yang wrote:
> On Tue, Feb 19, 2019 at 07:55:31PM +0100, Philippe Mathieu-Daudé wrote:
>> On 2/19/19 6:56 PM, Eric Blake wrote:
>>> On 2/19/19 11:38 AM, Philippe Mathieu-Daudé wrote:
>>>
> +if (a == 1) {
> +/* Reads like: "If a equals 1" */
I gu
On Tue, Feb 19, 2019 at 07:55:31PM +0100, Philippe Mathieu-Daudé wrote:
>On 2/19/19 6:56 PM, Eric Blake wrote:
>> On 2/19/19 11:38 AM, Philippe Mathieu-Daudé wrote:
>>
+if (a == 1) {
+/* Reads like: "If a equals 1" */
>>>
>>> I guess you found a bug in the documentation :)
>>
On Tue, Feb 19, 2019 at 06:38:54PM +0100, Philippe Mathieu-Daudé wrote:
>On 2/19/19 2:31 AM, Wei Yang wrote:
>> All the example code are indented with four spaces except this one.
>>
>> Fix this by adding four spaces here.
>>
>> Signed-off-by: Wei Yang
>> ---
>> CODING_STYLE | 8
>> 1
On 2/19/19 6:56 PM, Eric Blake wrote:
> On 2/19/19 11:38 AM, Philippe Mathieu-Daudé wrote:
>
>>> +if (a == 1) {
>>> +/* Reads like: "If a equals 1" */
>>
>> I guess you found a bug in the documentation :)
>>
>> Since 8c06fbdf36bf4d the style asked is:
>>
>> We now require Linux-ker
On 2/19/19 11:38 AM, Philippe Mathieu-Daudé wrote:
>> +if (a == 1) {
>> +/* Reads like: "If a equals 1" */
>
> I guess you found a bug in the documentation :)
>
> Since 8c06fbdf36bf4d the style asked is:
>
> We now require Linux-kernel-style multiline comments:
> /*
>
On 2/18/19 7:31 PM, Wei Yang wrote:
> All the example code are indented with four spaces except this one.
>
> Fix this by adding four spaces here.
>
> Signed-off-by: Wei Yang
> ---
> CODING_STYLE | 8
> 1 file changed, 4 insertions(+), 4 deletions(-)
Reviewed-by: Eric Blake
--
Eric
On 2/19/19 2:31 AM, Wei Yang wrote:
> All the example code are indented with four spaces except this one.
>
> Fix this by adding four spaces here.
>
> Signed-off-by: Wei Yang
> ---
> CODING_STYLE | 8
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/CODING_STYLE b/CO
All the example code are indented with four spaces except this one.
Fix this by adding four spaces here.
Signed-off-by: Wei Yang
---
CODING_STYLE | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/CODING_STYLE b/CODING_STYLE
index 73f66ca185..27581d80c1 100644
--- a/COD
