Re: [Qemu-devel] [PATCH 2/2] Xen: Add xen-apic support and hook it up.

2012-04-12 Thread Wei Liu
On Thu, Apr 12, 2012 at 1:02 AM, Eric Blake wrote: > On 04/11/2012 10:17 AM, Stefano Stabellini wrote: >> On Wed, 11 Apr 2012, Peter Maydell wrote: >>> On 5 April 2012 10:35, Wei Liu wrote: --- /dev/null +++ b/hw/xen_apic.c @@ -0,0 +1,90 @@ +/* + * Xen basic APIC sup

Re: [Qemu-devel] [PATCH 2/2] Xen: Add xen-apic support and hook it up.

2012-04-11 Thread Paolo Bonzini
Il 11/04/2012 18:17, Stefano Stabellini ha scritto: >> > Really 2-only, not 2-or-later ? > I am not a great fun of the 2-or-later clause and it doesn't look like a > requirement from the QEMU project POV. However if it is, I'll change it > to 2-or-later. OT fun fact: did you know that MPL comes wi

Re: [Qemu-devel] [PATCH 2/2] Xen: Add xen-apic support and hook it up.

2012-04-11 Thread Eric Blake
On 04/11/2012 10:17 AM, Stefano Stabellini wrote: > On Wed, 11 Apr 2012, Peter Maydell wrote: >> On 5 April 2012 10:35, Wei Liu wrote: >>> >>> --- /dev/null >>> +++ b/hw/xen_apic.c >>> @@ -0,0 +1,90 @@ >>> +/* >>> + * Xen basic APIC support >>> + * >>> + * Copyright (c) 2012 Citrix >>> + * >>> + *

Re: [Qemu-devel] [PATCH 2/2] Xen: Add xen-apic support and hook it up.

2012-04-11 Thread Peter Maydell
On 11 April 2012 17:13, Jan Kiszka wrote: > On 2012-04-11 18:07, Peter Maydell wrote: >>> +#include "hw/apic_internal.h" >>> +#include "hw/msi.h" >>> +#include "xen.h" >>> + >>> +static uint64_t xen_apic_mem_read(void *opaque, target_phys_addr_t addr, >>> +                                  unsigne

Re: [Qemu-devel] [PATCH 2/2] Xen: Add xen-apic support and hook it up.

2012-04-11 Thread Stefano Stabellini
On Wed, 11 Apr 2012, Stefano Stabellini wrote: > On Wed, 11 Apr 2012, Peter Maydell wrote: > > On 5 April 2012 10:35, Wei Liu wrote: > > > > > > --- /dev/null > > > +++ b/hw/xen_apic.c > > > @@ -0,0 +1,90 @@ > > > +/* > > > + * Xen basic APIC support > > > + * > > > + * Copyright (c) 2012 Citrix >

Re: [Qemu-devel] [PATCH 2/2] Xen: Add xen-apic support and hook it up.

2012-04-11 Thread Stefano Stabellini
On Wed, 11 Apr 2012, Peter Maydell wrote: > On 5 April 2012 10:35, Wei Liu wrote: > > > > --- /dev/null > > +++ b/hw/xen_apic.c > > @@ -0,0 +1,90 @@ > > +/* > > + * Xen basic APIC support > > + * > > + * Copyright (c) 2012 Citrix > > + * > > + * Authors: > > + *  Wei Liu > > + * > > + * This work

Re: [Qemu-devel] [PATCH 2/2] Xen: Add xen-apic support and hook it up.

2012-04-11 Thread Jan Kiszka
On 2012-04-11 18:07, Peter Maydell wrote: >> +#include "hw/apic_internal.h" >> +#include "hw/msi.h" >> +#include "xen.h" >> + >> +static uint64_t xen_apic_mem_read(void *opaque, target_phys_addr_t addr, >> + unsigned size) >> +{ >> +return -1U; >> +} > > This s

Re: [Qemu-devel] [PATCH 2/2] Xen: Add xen-apic support and hook it up.

2012-04-11 Thread Peter Maydell
On 5 April 2012 10:35, Wei Liu wrote: > > --- /dev/null > +++ b/hw/xen_apic.c > @@ -0,0 +1,90 @@ > +/* > + * Xen basic APIC support > + * > + * Copyright (c) 2012 Citrix > + * > + * Authors: > + *  Wei Liu > + * > + * This work is licensed under the terms of the GNU GPL version 2. > + * See the C

Re: [Qemu-devel] [PATCH 2/2] Xen: Add xen-apic support and hook it up.

2012-04-11 Thread Jan Kiszka
On 2012-04-11 18:02, Stefano Stabellini wrote: > Jan, Anthony, any opinions on this patch? > If it is OK for you, I am going to include it in the next Xen pull request. > Looks good to me. Jan > > On Thu, 5 Apr 2012, Wei Liu (Intern) wrote: >> >> Signed-off-by: Wei Liu >> --- >> Makefile.tar

Re: [Qemu-devel] [PATCH 2/2] Xen: Add xen-apic support and hook it up.

2012-04-11 Thread Stefano Stabellini
Jan, Anthony, any opinions on this patch? If it is OK for you, I am going to include it in the next Xen pull request. On Thu, 5 Apr 2012, Wei Liu (Intern) wrote: > > Signed-off-by: Wei Liu > --- > Makefile.target |2 +- > hw/pc.c |8 + > hw/xen_apic.c | 90 > ++

[Qemu-devel] [PATCH 2/2] Xen: Add xen-apic support and hook it up.

2012-04-05 Thread Wei Liu
Signed-off-by: Wei Liu --- Makefile.target |2 +- hw/pc.c |8 + hw/xen_apic.c | 90 +++ 3 files changed, 99 insertions(+), 1 deletions(-) create mode 100644 hw/xen_apic.c diff --git a/Makefile.target b/Makefile.target