Re: [Qemu-devel] [PATCH 2/2] bootdevice: add check in restore_boot_order()

2015-02-03 Thread Gonglei
On 2015/2/3 15:49, Markus Armbruster wrote: > You're right. pc.c's set_boot_dev() fails when its boot order argument > is invalid. > > The boot order interface is crap, because it makes detecting > configuration errors early hard. Two solutions: > > A. It may be hard, but not too hard for the

Re: [Qemu-devel] [PATCH 2/2] bootdevice: add check in restore_boot_order()

2015-02-02 Thread Markus Armbruster
Gonglei writes: > On 2015/2/2 17:37, Markus Armbruster wrote: > >> Gonglei writes: >> >>> On 2015/1/30 20:32, Markus Armbruster wrote: >>> Gonglei writes: > On 2015/1/30 20:01, Markus Armbruster wrote: > >> Gonglei writes: >> >>> On 2015/1/30 15:46, Markus Armbru

Re: [Qemu-devel] [PATCH 2/2] bootdevice: add check in restore_boot_order()

2015-02-02 Thread Gonglei
On 2015/2/2 17:37, Markus Armbruster wrote: > Gonglei writes: > >> On 2015/1/30 20:32, Markus Armbruster wrote: >> >>> Gonglei writes: >>> On 2015/1/30 20:01, Markus Armbruster wrote: > Gonglei writes: > >> On 2015/1/30 15:46, Markus Armbruster wrote: >> >>> Gongl

Re: [Qemu-devel] [PATCH 2/2] bootdevice: add check in restore_boot_order()

2015-02-02 Thread Markus Armbruster
Gonglei writes: > On 2015/1/30 20:32, Markus Armbruster wrote: > >> Gonglei writes: >> >>> On 2015/1/30 20:01, Markus Armbruster wrote: >>> Gonglei writes: > On 2015/1/30 15:46, Markus Armbruster wrote: > >> Gonglei writes: >> >>> On 2015/1/30 0:03, Alexander Gra

Re: [Qemu-devel] [PATCH 2/2] bootdevice: add check in restore_boot_order()

2015-01-30 Thread Gonglei
On 2015/1/30 20:32, Markus Armbruster wrote: > Gonglei writes: > >> On 2015/1/30 20:01, Markus Armbruster wrote: >> >>> Gonglei writes: >>> On 2015/1/30 15:46, Markus Armbruster wrote: > Gonglei writes: > >> On 2015/1/30 0:03, Alexander Graf wrote: >> >>> >>>

Re: [Qemu-devel] [PATCH 2/2] bootdevice: add check in restore_boot_order()

2015-01-30 Thread Markus Armbruster
Gonglei writes: > On 2015/1/30 20:01, Markus Armbruster wrote: > >> Gonglei writes: >> >>> On 2015/1/30 15:46, Markus Armbruster wrote: >>> Gonglei writes: > On 2015/1/30 0:03, Alexander Graf wrote: > >> >> >> On 29.01.15 14:29, arei.gong...@huawei.com wrote:

Re: [Qemu-devel] [PATCH 2/2] bootdevice: add check in restore_boot_order()

2015-01-30 Thread Gonglei
On 2015/1/30 20:01, Markus Armbruster wrote: > Gonglei writes: > >> On 2015/1/30 15:46, Markus Armbruster wrote: >> >>> Gonglei writes: >>> On 2015/1/30 0:03, Alexander Graf wrote: > > > On 29.01.15 14:29, arei.gong...@huawei.com wrote: >> From: Gonglei >> >>

Re: [Qemu-devel] [PATCH 2/2] bootdevice: add check in restore_boot_order()

2015-01-30 Thread Markus Armbruster
Gonglei writes: > On 2015/1/30 15:46, Markus Armbruster wrote: > >> Gonglei writes: >> >>> On 2015/1/30 0:03, Alexander Graf wrote: >>> On 29.01.15 14:29, arei.gong...@huawei.com wrote: > From: Gonglei > > If boot order is invaild or is set failed, > exit qemu. >

Re: [Qemu-devel] [PATCH 2/2] bootdevice: add check in restore_boot_order()

2015-01-30 Thread Gonglei
On 2015/1/30 15:46, Markus Armbruster wrote: > Gonglei writes: > >> On 2015/1/30 0:03, Alexander Graf wrote: >> >>> >>> >>> On 29.01.15 14:29, arei.gong...@huawei.com wrote: From: Gonglei If boot order is invaild or is set failed, exit qemu. Signed-off-by: Gonglei

Re: [Qemu-devel] [PATCH 2/2] bootdevice: add check in restore_boot_order()

2015-01-29 Thread Markus Armbruster
Gonglei writes: > On 2015/1/30 0:03, Alexander Graf wrote: > >> >> >> On 29.01.15 14:29, arei.gong...@huawei.com wrote: >>> From: Gonglei >>> >>> If boot order is invaild or is set failed, >>> exit qemu. >>> >>> Signed-off-by: Gonglei >> >> Do we really want to kill the machine only because

Re: [Qemu-devel] [PATCH 2/2] bootdevice: add check in restore_boot_order()

2015-01-29 Thread Gonglei
On 2015/1/30 0:03, Alexander Graf wrote: > > > On 29.01.15 14:29, arei.gong...@huawei.com wrote: >> From: Gonglei >> >> If boot order is invaild or is set failed, >> exit qemu. >> >> Signed-off-by: Gonglei > > Do we really want to kill the machine only because the boot device > string doesn't

Re: [Qemu-devel] [PATCH 2/2] bootdevice: add check in restore_boot_order()

2015-01-29 Thread Alexander Graf
On 29.01.15 14:29, arei.gong...@huawei.com wrote: > From: Gonglei > > If boot order is invaild or is set failed, > exit qemu. > > Signed-off-by: Gonglei Do we really want to kill the machine only because the boot device string doesn't validate? Alex > --- > bootdevice.c | 8 +++- > 1

[Qemu-devel] [PATCH 2/2] bootdevice: add check in restore_boot_order()

2015-01-29 Thread arei.gonglei
From: Gonglei If boot order is invaild or is set failed, exit qemu. Signed-off-by: Gonglei --- bootdevice.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/bootdevice.c b/bootdevice.c index 52d3f9e..8d05b8d 100644 --- a/bootdevice.c +++ b/bootdevice.c @@ -94,6 +94,7