[Qemu-devel] [PATCH 2/2] char: use a fixed idx for child muxed chr

2016-10-03 Thread Marc-André Lureau
mux_chr_update_read_handler() is adding a new mux_cnt each time mux_chr_update_read_handler() is called, it's not possible to actually update the "child" chr callbacks that were set previously. This may lead to crashes if the "child" chr is destroyed: valgrind x86_64-softmmu/qemu-system-x86_64 -ch

Re: [Qemu-devel] [PATCH 2/2] char: use a fixed idx for child muxed chr

2016-10-11 Thread Claudio Imbrenda
Hi, I noticed that this patch kills the Qemu monitor for me. If I start a text-mode guest with -nographic, then I can't switch to the monitor any longer with Ctrl+a c . The guest works otherwise, e.g. I can login from the console. Tested on s390, but I think it's a more general issue, since the p

Re: [Qemu-devel] [PATCH 2/2] char: use a fixed idx for child muxed chr

2016-10-11 Thread Marc-André Lureau
Hi On Tue, Oct 11, 2016 at 4:21 PM Claudio Imbrenda < imbre...@linux.vnet.ibm.com> wrote: > Hi, > > I noticed that this patch kills the Qemu monitor for me. If I start a > text-mode guest with -nographic, then I can't switch to the monitor any > longer with Ctrl+a c . The guest works otherwise, e

Re: [Qemu-devel] [PATCH 2/2] char: use a fixed idx for child muxed chr

2016-10-11 Thread Marc-André Lureau
Hi On Tue, Oct 11, 2016 at 6:28 PM Marc-André Lureau < marcandre.lur...@gmail.com> wrote: > Hi > > On Tue, Oct 11, 2016 at 4:21 PM Claudio Imbrenda < > imbre...@linux.vnet.ibm.com> wrote: > > Hi, > > I noticed that this patch kills the Qemu monitor for me. If I start a > text-mode guest with -nog

Re: [Qemu-devel] [PATCH 2/2] char: use a fixed idx for child muxed chr

2016-10-11 Thread Daniel P. Berrange
On Tue, Oct 11, 2016 at 04:18:46PM +, Marc-André Lureau wrote: > Hi > > On Tue, Oct 11, 2016 at 6:28 PM Marc-André Lureau < > marcandre.lur...@gmail.com> wrote: > > > Hi > > > > On Tue, Oct 11, 2016 at 4:21 PM Claudio Imbrenda < > > imbre...@linux.vnet.ibm.com> wrote: > > > > Hi, > > > > I no

Re: [Qemu-devel] [PATCH 2/2] char: use a fixed idx for child muxed chr

2016-10-12 Thread Marc-André Lureau
Hi On Tue, Oct 11, 2016 at 8:44 PM Daniel P. Berrange wrote: > > Not sure if this is immediately helpful to your scneario or > not, but I'd like to see the qemu_chr_add_handlers method > removed long term, and everything converted to use the > qemu_chr_fe_add_watch function instead. This reverse