Re: [Qemu-devel] [PATCH 2/2] hw/9pfs: fix alignment issue when host filesystem block size is larger than client msize

2016-03-02 Thread Jevon Qiao
Any further question/comment on this patch? Thanks, Jevon On 24/2/16 15:04, Jevon Qiao wrote: [Removing ceph-devel alias] Hi Aneesh, Any further comment on my reply below? Thanks, Jevon On 19/2/16 16:56, Jevon Qiao wrote: Hi Aneesh, I am not sure I understand the details correctly. iounit

Re: [Qemu-devel] [PATCH 2/2] hw/9pfs: fix alignment issue when host filesystem block size is larger than client msize

2016-02-23 Thread Jevon Qiao
[Removing ceph-devel alias] Hi Aneesh, Any further comment on my reply below? Thanks, Jevon On 19/2/16 16:56, Jevon Qiao wrote: Hi Aneesh, I am not sure I understand the details correctly. iounit is the size that we use in client_read to determine the size in which we should request I/O

Re: [Qemu-devel] [PATCH 2/2] hw/9pfs: fix alignment issue when host filesystem block size is larger than client msize

2016-02-19 Thread Jevon Qiao
Hi Greg, From: Jevon Qiao Date: Sun, 14 Feb 2016 15:11:08 +0800 Subject: [PATCH] hw/9pfs: fix alignment issue when host filesystem block size is larger than client msize. Per the previous implementation, iounit will be assigned to be 0 after the first if statement as

Re: [Qemu-devel] [PATCH 2/2] hw/9pfs: fix alignment issue when host filesystem block size is larger than client msize

2016-02-19 Thread Jevon Qiao
Hi Aneesh, I am not sure I understand the details correctly. iounit is the size that we use in client_read to determine the size in which we should request I/O from the client. But we still can't do I/O in size larger than s->msize. If you look at the client side (kernel 9p fs), you will find

Re: [Qemu-devel] [PATCH 2/2] hw/9pfs: fix alignment issue when host filesystem block size is larger than client msize

2016-02-17 Thread Aneesh Kumar K.V
Jevon Qiao writes: > Hi Aneesh, > > Thank you for reviewing my code, please see my reply in-line. > On 14/2/16 21:38, Aneesh Kumar K.V wrote: >> Jevon Qiao writes: >> >>> The following patch is to fix alignment issue when host filesystem block >>> size

Re: [Qemu-devel] [PATCH 2/2] hw/9pfs: fix alignment issue when host filesystem block size is larger than client msize

2016-02-17 Thread Greg Kurz
On Wed, 17 Feb 2016 15:14:48 +0800 Jevon Qiao wrote: > Hi Aneesh, > > Thank you for reviewing my code, please see my reply in-line. Jevon, Please read comments below. > On 14/2/16 21:38, Aneesh Kumar K.V wrote: > > Jevon Qiao writes: > > > >> The

Re: [Qemu-devel] [PATCH 2/2] hw/9pfs: fix alignment issue when host filesystem block size is larger than client msize

2016-02-16 Thread Jevon Qiao
Hi Aneesh, Thank you for reviewing my code, please see my reply in-line. On 14/2/16 21:38, Aneesh Kumar K.V wrote: Jevon Qiao writes: The following patch is to fix alignment issue when host filesystem block size is larger than client msize. Thanks, Jevon That is not

Re: [Qemu-devel] [PATCH 2/2] hw/9pfs: fix alignment issue when host filesystem block size is larger than client msize

2016-02-14 Thread Aneesh Kumar K.V
Jevon Qiao writes: > The following patch is to fix alignment issue when host filesystem block > size > is larger than client msize. > > Thanks, > Jevon That is not the right format to send patch. You can send them as a series using git-send-email. > > From: Jevon Qiao

[Qemu-devel] [PATCH 2/2] hw/9pfs: fix alignment issue when host filesystem block size is larger than client msize

2016-02-13 Thread Jevon Qiao
The following patch is to fix alignment issue when host filesystem block size is larger than client msize. Thanks, Jevon From: Jevon Qiao Date: Sun, 14 Feb 2016 15:11:08 +0800 Subject: [PATCH] hw/9pfs: fix alignment issue when host filesystem block size is larger than