Re: [Qemu-devel] [PATCH 2/2] libcacard: add libcacard.la target

2011-05-16 Thread Paolo Bonzini
On 05/15/2011 05:40 PM, Alon Levy wrote: -ln -s $source_path/libcacard/Makefile libcacard/Makefile +ln -s -f $source_path/libcacard/Makefile libcacard/Makefile Use the symlink function rather than ln -s -f for portability to broken platforms, please. Note that this requires libtool

Re: [Qemu-devel] [PATCH 2/2] libcacard: add libcacard.la target

2011-05-16 Thread Alon Levy
On Mon, May 16, 2011 at 09:00:10AM +0200, Paolo Bonzini wrote: On 05/15/2011 05:40 PM, Alon Levy wrote: -ln -s $source_path/libcacard/Makefile libcacard/Makefile +ln -s -f $source_path/libcacard/Makefile libcacard/Makefile Use the symlink function rather than ln -s -f for portability

Re: [Qemu-devel] [PATCH 2/2] libcacard: add libcacard.la target

2011-05-16 Thread Paolo Bonzini
On 05/16/2011 12:25 PM, Alon Levy wrote: Note that this requires libtool at build time rather than only for maintainers. This is unlike all other software using it. However, I believe this is not too bad given that a special make invocation is required. I was under the impression this

Re: [Qemu-devel] [PATCH 2/2] libcacard: add libcacard.la target

2011-05-16 Thread Gerd Hoffmann
Hi, Usually programs that are fully autoconf-iscated will ship a subset of libtool sources in the tarball, build a custom version at configure time, and invoke it from the Makefile via ./libtool. This has the advantage that only the maintainer needs to have libtool installed. OTOH we do not

Re: [Qemu-devel] [PATCH 2/2] libcacard: add libcacard.la target

2011-05-16 Thread Paolo Bonzini
On 05/16/2011 02:06 PM, Gerd Hoffmann wrote: Usually programs that are fully autoconf-iscated will ship a subset of libtool sources in the tarball, build a custom version at configure time, and invoke it from the Makefile via ./libtool. This has the advantage that only the maintainer needs to

Re: [Qemu-devel] [PATCH 2/2] libcacard: add libcacard.la target

2011-05-16 Thread Alon Levy
On Mon, May 16, 2011 at 02:07:55PM +0200, Paolo Bonzini wrote: On 05/16/2011 02:06 PM, Gerd Hoffmann wrote: Usually programs that are fully autoconf-iscated will ship a subset of libtool sources in the tarball, build a custom version at configure time, and invoke it from the Makefile via

Re: [Qemu-devel] [PATCH 2/2] libcacard: add libcacard.la target

2011-05-16 Thread Paolo Bonzini
On 05/16/2011 02:14 PM, Alon Levy wrote: On Mon, May 16, 2011 at 02:07:55PM +0200, Paolo Bonzini wrote: On 05/16/2011 02:06 PM, Gerd Hoffmann wrote: Usually programs that are fully autoconf-iscated will ship a subset of libtool sources in the tarball, build a custom version at configure time,

[Qemu-devel] [PATCH 2/2] libcacard: add libcacard.la target

2011-05-15 Thread Alon Levy
No flag to configure is required. Instead, added a libcacard.la target that is not built by default, only when requested explicitly via: mkdir build cd build ../configure make libcacard.la make install-libcacard Uses libtool to do actual linking of object files and shared library, and