Re: [Qemu-devel] [PATCH 2/2] libxl: introduce gfx_passthru_kind

2015-03-11 Thread Ian Campbell
On Mon, 2015-03-09 at 14:45 +0800, Chen, Tiejun wrote: > On 2015/3/6 20:55, Wei Liu wrote: > > On Fri, Mar 06, 2015 at 05:08:23PM +0800, Tiejun Chen wrote: > >> Although we already have 'gfx_passthru' in b_info, this doesn' suffice

Re: [Qemu-devel] [PATCH 2/2] libxl: introduce gfx_passthru_kind

2015-03-09 Thread Chen, Tiejun
On 2015/3/9 18:17, Wei Liu wrote: On Mon, Mar 09, 2015 at 02:45:36PM +0800, Chen, Tiejun wrote: [...] +exit (1); +} +} else if (!xlu_cfg_get_string(config, "gfx_passthru", &buf, 0)) { +if (libxl_gfx_passthru_kind_from_string(buf, &b_info->u.hvm.

Re: [Qemu-devel] [PATCH 2/2] libxl: introduce gfx_passthru_kind

2015-03-09 Thread Wei Liu
On Mon, Mar 09, 2015 at 02:45:36PM +0800, Chen, Tiejun wrote: [...] > > > >>+exit (1); > >>+} > >>+} else if (!xlu_cfg_get_string(config, "gfx_passthru", &buf, 0)) { > >>+if (libxl_gfx_passthru_kind_from_string(buf, > >>&b_info->u.hvm.gfx_passthru_ki

Re: [Qemu-devel] [PATCH 2/2] libxl: introduce gfx_passthru_kind

2015-03-09 Thread Wei Liu
On Mon, Mar 09, 2015 at 02:50:42PM +0800, Chen, Tiejun wrote: > On 2015/3/6 20:59, Wei Liu wrote: > >On Fri, Mar 06, 2015 at 05:18:36PM +0800, Chen, Tiejun wrote: > >>On 2015/3/6 17:08, Tiejun Chen wrote: > >>>Although we already have 'gfx_passthru' in b_info, this doesn' suffice > >>>after we want

Re: [Qemu-devel] [PATCH 2/2] libxl: introduce gfx_passthru_kind

2015-03-08 Thread Chen, Tiejun
On 2015/3/6 20:59, Wei Liu wrote: On Fri, Mar 06, 2015 at 05:18:36PM +0800, Chen, Tiejun wrote: On 2015/3/6 17:08, Tiejun Chen wrote: Although we already have 'gfx_passthru' in b_info, this doesn' suffice after we want to handle IGD specifically. Now we define a new field of type, gfx_passthru_

Re: [Qemu-devel] [PATCH 2/2] libxl: introduce gfx_passthru_kind

2015-03-08 Thread Chen, Tiejun
On 2015/3/6 20:55, Wei Liu wrote: On Fri, Mar 06, 2015 at 05:08:23PM +0800, Tiejun Chen wrote: Although we already have 'gfx_passthru' in b_info, this doesn' suffice after we want to handle IGD specifically. Now we define a new field of type, gfx_passthru_kind, to indicate we're trying to pass I

Re: [Qemu-devel] [PATCH 2/2] libxl: introduce gfx_passthru_kind

2015-03-06 Thread Wei Liu
On Fri, Mar 06, 2015 at 05:18:36PM +0800, Chen, Tiejun wrote: > On 2015/3/6 17:08, Tiejun Chen wrote: > >Although we already have 'gfx_passthru' in b_info, this doesn' suffice > >after we want to handle IGD specifically. Now we define a new field of > >type, gfx_passthru_kind, to indicate we're try

Re: [Qemu-devel] [PATCH 2/2] libxl: introduce gfx_passthru_kind

2015-03-06 Thread Wei Liu
On Fri, Mar 06, 2015 at 05:08:23PM +0800, Tiejun Chen wrote: > Although we already have 'gfx_passthru' in b_info, this doesn' suffice > after we want to handle IGD specifically. Now we define a new field of > type, gfx_passthru_kind, to indicate we're trying to pass IGD. Actually > this means we ca

Re: [Qemu-devel] [PATCH 2/2] libxl: introduce gfx_passthru_kind

2015-03-06 Thread Chen, Tiejun
On 2015/3/6 17:08, Tiejun Chen wrote: Although we already have 'gfx_passthru' in b_info, this doesn' suffice after we want to handle IGD specifically. Now we define a new field of type, gfx_passthru_kind, to indicate we're trying to pass IGD. Actually this means we can benefit this to support oth

[Qemu-devel] [PATCH 2/2] libxl: introduce gfx_passthru_kind

2015-03-06 Thread Tiejun Chen
Although we already have 'gfx_passthru' in b_info, this doesn' suffice after we want to handle IGD specifically. Now we define a new field of type, gfx_passthru_kind, to indicate we're trying to pass IGD. Actually this means we can benefit this to support other specific devices just by extending gf