Re: [Qemu-devel] [PATCH 2/2] lsi: use ldn_le_p()/stn_le_p()

2019-02-18 Thread Sven Schnelle
Hi Philippe, On Mon, Feb 18, 2019 at 10:39:54PM +0100, Philippe Mathieu-Daudé wrote: > > -newval = s->script_ram[addr >> 2]; > > -shift = (addr & 3) * 8; > > -mask = ((uint64_t)1 << (size * 8)) - 1; > > -newval &= ~(mask << shift); > > -newval |= val << shift; > > -s->scri

Re: [Qemu-devel] [PATCH 2/2] lsi: use ldn_le_p()/stn_le_p()

2019-02-18 Thread Peter Maydell
On Mon, 18 Feb 2019 at 21:41, Philippe Mathieu-Daudé wrote: > > Hi Sven, > > On 2/18/19 6:55 PM, Sven Schnelle wrote: > > Signed-off-by: Sven Schnelle > > --- > > hw/scsi/lsi53c895a.c | 19 ++- > > 1 file changed, 2 insertions(+), 17 deletions(-) > > > > diff --git a/hw/scsi/lsi5

Re: [Qemu-devel] [PATCH 2/2] lsi: use ldn_le_p()/stn_le_p()

2019-02-18 Thread Philippe Mathieu-Daudé
Hi Sven, On 2/18/19 6:55 PM, Sven Schnelle wrote: > Signed-off-by: Sven Schnelle > --- > hw/scsi/lsi53c895a.c | 19 ++- > 1 file changed, 2 insertions(+), 17 deletions(-) > > diff --git a/hw/scsi/lsi53c895a.c b/hw/scsi/lsi53c895a.c > index c493e3c4c7..93c4434bfb 100644 > --- a/h

[Qemu-devel] [PATCH 2/2] lsi: use ldn_le_p()/stn_le_p()

2019-02-18 Thread Sven Schnelle
Signed-off-by: Sven Schnelle --- hw/scsi/lsi53c895a.c | 19 ++- 1 file changed, 2 insertions(+), 17 deletions(-) diff --git a/hw/scsi/lsi53c895a.c b/hw/scsi/lsi53c895a.c index c493e3c4c7..93c4434bfb 100644 --- a/hw/scsi/lsi53c895a.c +++ b/hw/scsi/lsi53c895a.c @@ -2078,29 +2078,14