[Qemu-devel] [PATCH 2/2] machine_parse(): list supported machine types in their registration order

2014-09-22 Thread Laszlo Ersek
Based on the registration order captured in the previous patch, we sort the ad-hoc list printed for qemu-system- -M \? The GLib documentation is not overly clear if g_slist_sort() allocates a new list or reorders the input list in place, but: - it slightly suggests the latter, - and there

Re: [Qemu-devel] [PATCH 2/2] machine_parse(): list supported machine types in their registration order

2014-09-22 Thread Andreas Färber
Am 22.09.2014 um 13:26 schrieb Laszlo Ersek: Based on the registration order captured in the previous patch, we sort the ad-hoc list printed for qemu-system- -M \? Agree that the order is worth sanitizing. I would however argue that registration order is not entirely stable either if

Re: [Qemu-devel] [PATCH 2/2] machine_parse(): list supported machine types in their registration order

2014-09-22 Thread Michael S. Tsirkin
On Mon, Sep 22, 2014 at 02:04:44PM +0200, Andreas Färber wrote: Am 22.09.2014 um 13:26 schrieb Laszlo Ersek: Based on the registration order captured in the previous patch, we sort the ad-hoc list printed for qemu-system- -M \? Agree that the order is worth sanitizing. I would

Re: [Qemu-devel] [PATCH 2/2] machine_parse(): list supported machine types in their registration order

2014-09-22 Thread Laszlo Ersek
On 09/22/14 14:04, Andreas Färber wrote: Am 22.09.2014 um 13:26 schrieb Laszlo Ersek: Based on the registration order captured in the previous patch, we sort the ad-hoc list printed for qemu-system- -M \? Agree that the order is worth sanitizing. I would however argue that

Re: [Qemu-devel] [PATCH 2/2] machine_parse(): list supported machine types in their registration order

2014-09-22 Thread Michael S. Tsirkin
On Mon, Sep 22, 2014 at 02:29:08PM +0200, Laszlo Ersek wrote: On 09/22/14 14:04, Andreas Färber wrote: Am 22.09.2014 um 13:26 schrieb Laszlo Ersek: Based on the registration order captured in the previous patch, we sort the ad-hoc list printed for qemu-system- -M \? Agree that

Re: [Qemu-devel] [PATCH 2/2] machine_parse(): list supported machine types in their registration order

2014-09-22 Thread Marcel Apfelbaum
On Mon, 2014-09-22 at 15:36 +0300, Michael S. Tsirkin wrote: On Mon, Sep 22, 2014 at 02:29:08PM +0200, Laszlo Ersek wrote: On 09/22/14 14:04, Andreas Färber wrote: Am 22.09.2014 um 13:26 schrieb Laszlo Ersek: Based on the registration order captured in the previous patch, we sort the

Re: [Qemu-devel] [PATCH 2/2] machine_parse(): list supported machine types in their registration order

2014-09-22 Thread Laszlo Ersek
On 09/22/14 14:36, Michael S. Tsirkin wrote: On Mon, Sep 22, 2014 at 02:29:08PM +0200, Laszlo Ersek wrote: On 09/22/14 14:04, Andreas Färber wrote: Am 22.09.2014 um 13:26 schrieb Laszlo Ersek: Based on the registration order captured in the previous patch, we sort the ad-hoc list printed for

Re: [Qemu-devel] [PATCH 2/2] machine_parse(): list supported machine types in their registration order

2014-09-22 Thread Laszlo Ersek
On 09/22/14 14:50, Marcel Apfelbaum wrote: On Mon, 2014-09-22 at 15:36 +0300, Michael S. Tsirkin wrote: On Mon, Sep 22, 2014 at 02:29:08PM +0200, Laszlo Ersek wrote: On 09/22/14 14:04, Andreas Färber wrote: Am 22.09.2014 um 13:26 schrieb Laszlo Ersek: Based on the registration order captured

Re: [Qemu-devel] [PATCH 2/2] machine_parse(): list supported machine types in their registration order

2014-09-22 Thread Marcel Apfelbaum
On Mon, 2014-09-22 at 15:43 +0200, Laszlo Ersek wrote: On 09/22/14 14:50, Marcel Apfelbaum wrote: On Mon, 2014-09-22 at 15:36 +0300, Michael S. Tsirkin wrote: On Mon, Sep 22, 2014 at 02:29:08PM +0200, Laszlo Ersek wrote: On 09/22/14 14:04, Andreas Färber wrote: Am 22.09.2014 um 13:26

Re: [Qemu-devel] [PATCH 2/2] machine_parse(): list supported machine types in their registration order

2014-09-22 Thread Paolo Bonzini
Il 22/09/2014 15:15, Laszlo Ersek ha scritto: $ git grep -E '\qemu_register(_pc)?_machine\' | wc -l 115 Even if we just count the clusters, they're way too many: $ git grep -E '\machine_init\' | wc -l 66 There are just a couple of multi-machine clusters (well, three: pseries, pc, q35).

Re: [Qemu-devel] [PATCH 2/2] machine_parse(): list supported machine types in their registration order

2014-09-22 Thread Andreas Färber
Am 22.09.2014 um 17:57 schrieb Paolo Bonzini: Il 22/09/2014 15:15, Laszlo Ersek ha scritto: $ git grep -E '\qemu_register(_pc)?_machine\' | wc -l 115 Even if we just count the clusters, they're way too many: $ git grep -E '\machine_init\' | wc -l 66 There are just a couple of

Re: [Qemu-devel] [PATCH 2/2] machine_parse(): list supported machine types in their registration order

2014-09-22 Thread Laszlo Ersek
On 09/22/14 17:57, Paolo Bonzini wrote: Il 22/09/2014 15:15, Laszlo Ersek ha scritto: $ git grep -E '\qemu_register(_pc)?_machine\' | wc -l 115 Even if we just count the clusters, they're way too many: $ git grep -E '\machine_init\' | wc -l 66 There are just a couple of multi-machine

Re: [Qemu-devel] [PATCH 2/2] machine_parse(): list supported machine types in their registration order

2014-09-22 Thread Paolo Bonzini
Il 22/09/2014 18:06, Andreas Färber ha scritto: Am 22.09.2014 um 17:57 schrieb Paolo Bonzini: Il 22/09/2014 15:15, Laszlo Ersek ha scritto: $ git grep -E '\qemu_register(_pc)?_machine\' | wc -l 115 Even if we just count the clusters, they're way too many: $ git grep -E '\machine_init\' |