* Cornelia Huck (cornelia.h...@de.ibm.com) wrote:
> On Thu, 21 Jan 2016 21:56:22 +0100
> Sascha Silbe wrote:
>
> > "Dr. David Alan Gilbert" writes:
>
> > > Thanks I've reused a chunk of that; I'll post the fix soon.
> > > Thanks for your help on this.
> >
> > Thanks, looking forward to the ne
On Thu, 21 Jan 2016 21:56:22 +0100
Sascha Silbe wrote:
> "Dr. David Alan Gilbert" writes:
> > Thanks I've reused a chunk of that; I'll post the fix soon.
> > Thanks for your help on this.
>
> Thanks, looking forward to the next version of your patch. Will use the
> the previous one in the mea
Dear David,
"Dr. David Alan Gilbert" writes:
>
>
Interesting, didn't know about --global yet. Thanks for posting the
example. That will come in handy for my tests.
> Thanks I've reused a chunk of that; I'll post the fix soon.
> Thanks for your help on this.
Thanks, looking forward
* Sascha Silbe (si...@linux.vnet.ibm.com) wrote:
> Dear David,
>
> "Dr. David Alan Gilbert" writes:
>
> > Can you try this and let me know if it fixes it for you; I've
> > still not managed to persuade x86-64 to fail.
>
> With Conny's hint re. virtio-1 (thanks!) I managed to make it fail on
>
* Sascha Silbe (si...@linux.vnet.ibm.com) wrote:
> Dear David,
>
> "Dr. David Alan Gilbert" writes:
>
> > +/* a variable length array (i.e. _type *_field) but we know the
> > + * length
> > + */
> > +#define VMSTATE_STRUCT_VARRAY_POINTER_KNOWN(_field, _state, _num,
> > _version, _vmsd, _type) {
Dear David,
"Dr. David Alan Gilbert" writes:
> +/* a variable length array (i.e. _type *_field) but we know the
> + * length
> + */
> +#define VMSTATE_STRUCT_VARRAY_POINTER_KNOWN(_field, _state, _num, _version,
> _vmsd, _type) { \
[...]
Thinking about it some more, wouldn't VMSTATE_STRUCT_ARRA
Dear David,
"Dr. David Alan Gilbert" writes:
> Can you try this and let me know if it fixes it for you; I've
> still not managed to persuade x86-64 to fail.
With Conny's hint re. virtio-1 (thanks!) I managed to make it fail on
x86_64, too. I'm using libvirt for testing (virDomainSave() /
virD
On Fri, 15 Jan 2016 12:01:44 +
"Dr. David Alan Gilbert" wrote:
> I misunderstood the vmstate macro definition when
> I reworked the virtio .get/.put - but I can't
> get it to break for me, which suggests I'm perhaps
> not managing to get that structure into being
> sent in my tests.
The firs
Hi Sascha,
Can you try this and let me know if it fixes it for you; I've
still not managed to persuade x86-64 to fail.
Dave
From f300fa0dd902b28417744d364986c71dd8357a88 Mon Sep 17 00:00:00 2001
From: "Dr. David Alan Gilbert"
Date: Fri, 15 Jan 2016 11:02:02 +
Subject: [PATCH] Fix virito m
* Sascha Silbe (si...@linux.vnet.ibm.com) wrote:
> Dear David,
Hi Sascha,
Thanks for the mail.
> "Dr. David Alan Gilbert (git)" writes:
>
> > The 'virtqueue_state' and 'ringsize' can be saved using VMSTATE
> > macros rather than hand coded .get/.put
> [...]
> > @@ -1161,44 +1143,20 @@ static
Dear David,
"Dr. David Alan Gilbert (git)" writes:
> The 'virtqueue_state' and 'ringsize' can be saved using VMSTATE
> macros rather than hand coded .get/.put
[...]
> @@ -1161,44 +1143,20 @@ static const VMStateDescription
> vmstate_virtio_virtqueues = {
> .minimum_version_id = 1,
> .
On (Wed) 06 Jan 2016 [12:23:39], Dr. David Alan Gilbert (git) wrote:
> From: "Dr. David Alan Gilbert"
>
> The 'virtqueue_state' and 'ringsize' can be saved using VMSTATE
> macros rather than hand coded .get/.put
>
> Signed-off-by: Dr. David Alan Gilbert
Reviewed-by: Amit Shah
From: "Dr. David Alan Gilbert"
The 'virtqueue_state' and 'ringsize' can be saved using VMSTATE
macros rather than hand coded .get/.put
Signed-off-by: Dr. David Alan Gilbert
---
hw/virtio/virtio.c | 87 --
1 file changed, 19 insertions(+), 68
13 matches
Mail list logo
