Re: [Qemu-devel] [PATCH 2/2] osdep: warn if open(O_DIRECT) on fails with EINVAL

2013-09-18 Thread Stefan Hajnoczi
On Fri, Sep 06, 2013 at 04:32:43PM -0400, Jeff Cody wrote: On Thu, Aug 22, 2013 at 11:29:03AM +0200, Stefan Hajnoczi wrote: Print a warning when opening a file O_DIRECT fails with EINVAL. This saves users a lot of time trying to figure out the EINVAL error, which is typical when attempting

Re: [Qemu-devel] [PATCH 2/2] osdep: warn if open(O_DIRECT) on fails with EINVAL

2013-09-06 Thread Jeff Cody
On Thu, Aug 22, 2013 at 11:29:03AM +0200, Stefan Hajnoczi wrote: Print a warning when opening a file O_DIRECT fails with EINVAL. This saves users a lot of time trying to figure out the EINVAL error, which is typical when attempting to open a file O_DIRECT on Linux tmpfs. Reported-by: Deepak

[Qemu-devel] [PATCH 2/2] osdep: warn if open(O_DIRECT) on fails with EINVAL

2013-08-22 Thread Stefan Hajnoczi
Print a warning when opening a file O_DIRECT fails with EINVAL. This saves users a lot of time trying to figure out the EINVAL error, which is typical when attempting to open a file O_DIRECT on Linux tmpfs. Reported-by: Deepak C Shetty deepa...@linux.vnet.ibm.com Signed-off-by: Stefan Hajnoczi

Re: [Qemu-devel] [PATCH 2/2] osdep: warn if open(O_DIRECT) on fails with EINVAL

2013-08-22 Thread Eric Blake
On 08/22/2013 03:29 AM, Stefan Hajnoczi wrote: Print a warning when opening a file O_DIRECT fails with EINVAL. This saves users a lot of time trying to figure out the EINVAL error, which is typical when attempting to open a file O_DIRECT on Linux tmpfs. Reported-by: Deepak C Shetty

Re: [Qemu-devel] [PATCH 2/2] osdep: warn if open(O_DIRECT) on fails with EINVAL

2013-08-22 Thread Alex Bligh
--On 22 August 2013 11:57:56 -0600 Eric Blake ebl...@redhat.com wrote: # define O_DIRECT 0 so that the rest of the code can just blindly use open(...,|O_DIRECT) (provided, of course, that not having O_DIRECT semantics is not fatal...). If that is done, then this #ifdef will always be

Re: [Qemu-devel] [PATCH 2/2] osdep: warn if open(O_DIRECT) on fails with EINVAL

2013-08-22 Thread Eric Blake
On 08/22/2013 01:31 PM, Alex Bligh wrote: --On 22 August 2013 11:57:56 -0600 Eric Blake ebl...@redhat.com wrote: # define O_DIRECT 0 so that the rest of the code can just blindly use open(...,|O_DIRECT) (provided, of course, that not having O_DIRECT semantics is not fatal...). If that