Re: [Qemu-devel] [PATCH 2/2] pci: rewrite devaddr parsing

2012-02-19 Thread Michael S. Tsirkin
On Fri, Feb 17, 2012 at 01:35:02PM +0100, Markus Armbruster wrote: > "Michael S. Tsirkin" writes: > > > On Thu, Feb 16, 2012 at 01:39:02PM -0700, Eric Blake wrote: > >> On 02/16/2012 12:23 PM, malc wrote: > >> > On Thu, 16 Feb 2012, Michael S. Tsirkin wrote: > >> > > >> >> Use scanf instead of m

Re: [Qemu-devel] [PATCH 2/2] pci: rewrite devaddr parsing

2012-02-19 Thread Michael S. Tsirkin
On Fri, Feb 17, 2012 at 01:35:02PM +0100, Markus Armbruster wrote: > "Michael S. Tsirkin" writes: > > > On Thu, Feb 16, 2012 at 01:39:02PM -0700, Eric Blake wrote: > >> On 02/16/2012 12:23 PM, malc wrote: > >> > On Thu, 16 Feb 2012, Michael S. Tsirkin wrote: > >> > > >> >> Use scanf instead of m

Re: [Qemu-devel] [PATCH 2/2] pci: rewrite devaddr parsing

2012-02-17 Thread Markus Armbruster
"Michael S. Tsirkin" writes: > On Thu, Feb 16, 2012 at 01:39:02PM -0700, Eric Blake wrote: >> On 02/16/2012 12:23 PM, malc wrote: >> > On Thu, 16 Feb 2012, Michael S. Tsirkin wrote: >> > >> >> Use scanf instead of manual string scanning. >> >> >> >> + >> >> +/* Parse [[:]:] */ >> >> +ssc

Re: [Qemu-devel] [PATCH 2/2] pci: rewrite devaddr parsing

2012-02-17 Thread Michael S. Tsirkin
On Fri, Feb 17, 2012 at 01:50:41PM +0400, malc wrote: > On Fri, 17 Feb 2012, Michael S. Tsirkin wrote: > > > On Thu, Feb 16, 2012 at 11:23:40PM +0400, malc wrote: > > > > +{ > > > > +unsigned dom, bus, slot, func; > > > > +int n = -1; > > > > + > > > > +/* Parse [[:]:] */ > > > > +

Re: [Qemu-devel] [PATCH 2/2] pci: rewrite devaddr parsing

2012-02-17 Thread Michael S. Tsirkin
On Thu, Feb 16, 2012 at 01:39:02PM -0700, Eric Blake wrote: > On 02/16/2012 12:23 PM, malc wrote: > > On Thu, 16 Feb 2012, Michael S. Tsirkin wrote: > > > >> Use scanf instead of manual string scanning. > >> > >> + > >> +/* Parse [[:]:] */ > >> +sscanf(addr, "%x:%x:%x%n", &dom, &bus, &slot

Re: [Qemu-devel] [PATCH 2/2] pci: rewrite devaddr parsing

2012-02-17 Thread malc
On Fri, 17 Feb 2012, Michael S. Tsirkin wrote: > On Thu, Feb 16, 2012 at 11:23:40PM +0400, malc wrote: > > > +{ > > > +unsigned dom, bus, slot, func; > > > +int n = -1; > > > + > > > +/* Parse [[:]:] */ > > > +sscanf(addr, "%x:%x:%x%n", &dom, &bus, &slot, &n); > > > > sscanf can f

Re: [Qemu-devel] [PATCH 2/2] pci: rewrite devaddr parsing

2012-02-17 Thread Michael S. Tsirkin
On Thu, Feb 16, 2012 at 11:23:40PM +0400, malc wrote: > > +{ > > +unsigned dom, bus, slot, func; > > +int n = -1; > > + > > +/* Parse [[:]:] */ > > +sscanf(addr, "%x:%x:%x%n", &dom, &bus, &slot, &n); > > sscanf can fail. > > > +if (n == -1) { If it does n will stay -1.

Re: [Qemu-devel] [PATCH 2/2] pci: rewrite devaddr parsing

2012-02-16 Thread malc
On Thu, 16 Feb 2012, Eric Blake wrote: > On 02/16/2012 12:23 PM, malc wrote: > > On Thu, 16 Feb 2012, Michael S. Tsirkin wrote: > > > >> Use scanf instead of manual string scanning. > >> > >> + > >> +/* Parse [[:]:] */ > >> +sscanf(addr, "%x:%x:%x%n", &dom, &bus, &slot, &n); > > > > ssca

Re: [Qemu-devel] [PATCH 2/2] pci: rewrite devaddr parsing

2012-02-16 Thread Eric Blake
On 02/16/2012 12:23 PM, malc wrote: > On Thu, 16 Feb 2012, Michael S. Tsirkin wrote: > >> Use scanf instead of manual string scanning. >> >> + >> +/* Parse [[:]:] */ >> +sscanf(addr, "%x:%x:%x%n", &dom, &bus, &slot, &n); > > sscanf can fail. Worse, the *scanf family has undefined behavio

Re: [Qemu-devel] [PATCH 2/2] pci: rewrite devaddr parsing

2012-02-16 Thread malc
On Thu, 16 Feb 2012, Michael S. Tsirkin wrote: > Use scanf instead of manual string scanning. > > Signed-off-by: Michael S. Tsirkin > --- > hw/pci.c | 81 > +- > 1 files changed, 38 insertions(+), 43 deletions(-) > > diff --git a/h

[Qemu-devel] [PATCH 2/2] pci: rewrite devaddr parsing

2012-02-16 Thread Michael S. Tsirkin
Use scanf instead of manual string scanning. Signed-off-by: Michael S. Tsirkin --- hw/pci.c | 81 +- 1 files changed, 38 insertions(+), 43 deletions(-) diff --git a/hw/pci.c b/hw/pci.c index 5827c0e..a8c0b69 100644 --- a/hw/pci.c +++