Re: [Qemu-devel] [PATCH 2/2] pcie_aer: clear cmask for Advanced Error Interrupt Message Number

2012-08-31 Thread Jason Baron
On Fri, Aug 31, 2012 at 06:35:13PM +0300, Michael S. Tsirkin wrote: > On Fri, Aug 31, 2012 at 10:45:52AM -0400, Jason Baron wrote: > > On Fri, Aug 31, 2012 at 11:42:27AM +0300, Michael S. Tsirkin wrote: > > > Some minor nits below. If you dont get to it I will tweak this patch > > > when I apply it

Re: [Qemu-devel] [PATCH 2/2] pcie_aer: clear cmask for Advanced Error Interrupt Message Number

2012-08-31 Thread Michael S. Tsirkin
On Fri, Aug 31, 2012 at 10:45:52AM -0400, Jason Baron wrote: > On Fri, Aug 31, 2012 at 11:42:27AM +0300, Michael S. Tsirkin wrote: > > Some minor nits below. If you dont get to it I will tweak this patch > > when I apply it early next week. > > > > On Thu, Aug 30, 2012 at 01:51:15PM -0400, Jason B

Re: [Qemu-devel] [PATCH 2/2] pcie_aer: clear cmask for Advanced Error Interrupt Message Number

2012-08-31 Thread Jason Baron
On Fri, Aug 31, 2012 at 11:42:27AM +0300, Michael S. Tsirkin wrote: > Some minor nits below. If you dont get to it I will tweak this patch > when I apply it early next week. > > On Thu, Aug 30, 2012 at 01:51:15PM -0400, Jason Baron wrote: > > The Advanced Error Interrupt Message Number (bits 31:27

Re: [Qemu-devel] [PATCH 2/2] pcie_aer: clear cmask for Advanced Error Interrupt Message Number

2012-08-31 Thread Michael S. Tsirkin
Some minor nits below. If you dont get to it I will tweak this patch when I apply it early next week. On Thu, Aug 30, 2012 at 01:51:15PM -0400, Jason Baron wrote: > The Advanced Error Interrupt Message Number (bits 31:27 of the Root > Error Status Register) is updated when the number of msi messa

[Qemu-devel] [PATCH 2/2] pcie_aer: clear cmask for Advanced Error Interrupt Message Number

2012-08-30 Thread Jason Baron
The Advanced Error Interrupt Message Number (bits 31:27 of the Root Error Status Register) is updated when the number of msi messages assigned to a device changes. Migration of windows 7 on q35 chipset failed because the check in get_pci_config_device() fails due to wmask being set on these bits. I