Re: [Qemu-devel] [PATCH 2/2] postcopy: Require RAMBlocks that are whole pages

2017-05-18 Thread Peter Xu
On Thu, May 18, 2017 at 09:08:34AM +0100, Dr. David Alan Gilbert wrote: > * Juan Quintela (quint...@redhat.com) wrote: > > "Dr. David Alan Gilbert (git)" wrote: > > > From: "Dr. David Alan Gilbert" > > > > > > It turns out that it's legal to create a VM with RAMBlocks that aren't > > > a multiple

Re: [Qemu-devel] [PATCH 2/2] postcopy: Require RAMBlocks that are whole pages

2017-05-18 Thread Dr. David Alan Gilbert
* Juan Quintela (quint...@redhat.com) wrote: > "Dr. David Alan Gilbert (git)" wrote: > > From: "Dr. David Alan Gilbert" > > > > It turns out that it's legal to create a VM with RAMBlocks that aren't > > a multiple of the pagesize in use; e.g. a 1025M main memory using > > 2M host pages. That bre

Re: [Qemu-devel] [PATCH 2/2] postcopy: Require RAMBlocks that are whole pages

2017-05-17 Thread Juan Quintela
"Dr. David Alan Gilbert (git)" wrote: > From: "Dr. David Alan Gilbert" > > It turns out that it's legal to create a VM with RAMBlocks that aren't > a multiple of the pagesize in use; e.g. a 1025M main memory using > 2M host pages. That breaks postcopy's atomic placement of pages, > so disallow i

[Qemu-devel] [PATCH 2/2] postcopy: Require RAMBlocks that are whole pages

2017-05-17 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" It turns out that it's legal to create a VM with RAMBlocks that aren't a multiple of the pagesize in use; e.g. a 1025M main memory using 2M host pages. That breaks postcopy's atomic placement of pages, so disallow it. Signed-off-by: Dr. David Alan Gilbert --- mi