Re: [Qemu-devel] [PATCH 2/2] qdev: print error message before aborting

2012-02-17 Thread Paolo Bonzini
On 02/17/2012 05:30 PM, Peter Maydell wrote: > So now you get: > qemu-system-arm: Insufficient permission to perform this operation > Aborted > > This still isn't really very diagnostic: I had to run the whole > thing under a debugger and look at the backtrace anyway before > I realised I'd hit th

Re: [Qemu-devel] [PATCH 2/2] qdev: print error message before aborting

2012-02-17 Thread Peter Maydell
On 14 February 2012 09:19, Paolo Bonzini wrote: > qdev_prop_set_* functions are always called by machine init functions > that should know what they're doing, so they abort on error.  Still, > an assert(!errp) does not aid debugging.  Print an error before aborting. So now you get: qemu-system-ar

[Qemu-devel] [PATCH 2/2] qdev: print error message before aborting

2012-02-14 Thread Paolo Bonzini
qdev_prop_set_* functions are always called by machine init functions that should know what they're doing, so they abort on error. Still, an assert(!errp) does not aid debugging. Print an error before aborting. Signed-off-by: Paolo Bonzini --- hw/qdev-properties.c | 26 +-