Re: [Qemu-devel] [PATCH 2/2] qemu queue: fix uninitialized removals

2012-10-18 Thread Peter Maydell
On 14 October 2012 14:08, Tim Hardeck wrote: > When calling QTAILQ_REMOVE or QLIST_REMOVE on an unitialized list > QEMU segfaults. > > Check for this case specifically on item removal. Incidentally, this commit message is inaccurate -- you can't call the _REMOVE macros on a list (uninitialised or

Re: [Qemu-devel] [PATCH 2/2] qemu queue: fix uninitialized removals

2012-10-18 Thread Peter Maydell
On 18 October 2012 11:43, Kevin Wolf wrote: > Am 17.10.2012 23:24, schrieb Tim Hardeck: >> On Wednesday 17 October 2012 17:00:15 Andreas Färber wrote: >>> Am 14.10.2012 15:08, schrieb Tim Hardeck: When calling QTAILQ_REMOVE or QLIST_REMOVE on an unitialized list QEMU segfaults. >>> >>> C

Re: [Qemu-devel] [PATCH 2/2] qemu queue: fix uninitialized removals

2012-10-18 Thread Andreas Färber
Am 18.10.2012 12:43, schrieb Kevin Wolf: > Am 17.10.2012 23:24, schrieb Tim Hardeck: >> On Wednesday 17 October 2012 17:00:15 Andreas Färber wrote: >>> Am 14.10.2012 15:08, schrieb Tim Hardeck: When calling QTAILQ_REMOVE or QLIST_REMOVE on an unitialized list QEMU segfaults. >>> >>> Can t

Re: [Qemu-devel] [PATCH 2/2] qemu queue: fix uninitialized removals

2012-10-18 Thread Kevin Wolf
Am 17.10.2012 23:24, schrieb Tim Hardeck: > Hi Andreas, > > On Wednesday 17 October 2012 17:00:15 Andreas Färber wrote: >> Tim, >> >> Am 14.10.2012 15:08, schrieb Tim Hardeck: >>> When calling QTAILQ_REMOVE or QLIST_REMOVE on an unitialized list >>> QEMU segfaults. >> >> Can this be reproduced by

Re: [Qemu-devel] [PATCH 2/2] qemu queue: fix uninitialized removals

2012-10-17 Thread Tim Hardeck
Hi Andreas, On Wednesday 17 October 2012 17:00:15 Andreas Färber wrote: > Tim, > > Am 14.10.2012 15:08, schrieb Tim Hardeck: > > When calling QTAILQ_REMOVE or QLIST_REMOVE on an unitialized list > > QEMU segfaults. > > Can this be reproduced by a user today? Or is this just fixing the case > that

Re: [Qemu-devel] [PATCH 2/2] qemu queue: fix uninitialized removals

2012-10-17 Thread Andreas Färber
Tim, Am 14.10.2012 15:08, schrieb Tim Hardeck: > When calling QTAILQ_REMOVE or QLIST_REMOVE on an unitialized list > QEMU segfaults. Can this be reproduced by a user today? Or is this just fixing the case that a developer forgot to initialize a list? Regards, Andreas > Check for this case speci

[Qemu-devel] [PATCH 2/2] qemu queue: fix uninitialized removals

2012-10-14 Thread Tim Hardeck
When calling QTAILQ_REMOVE or QLIST_REMOVE on an unitialized list QEMU segfaults. Check for this case specifically on item removal. Signed-off-by: Tim Hardeck --- qemu-queue.h |8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/qemu-queue.h b/qemu-queue.h index 9288cd

[Qemu-devel] [PATCH 2/2] qemu queue: fix uninitialized removals

2012-10-09 Thread Tim Hardeck
When calling QTAILQ_REMOVE or QLIST_REMOVE on an unitialized list QEMU segfaults. Check for this case specifically on item removal. Signed-off-by: Tim Hardeck --- qemu-queue.h |8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/qemu-queue.h b/qemu-queue.h index 9288cd