Re: [Qemu-devel] [PATCH 2/2] rbd: disable unsupported librbd functions at runtime

2013-04-05 Thread Kevin Wolf
Am 04.04.2013 um 18:50 hat Josh Durgin geschrieben: > On 04/04/2013 03:10 AM, Kevin Wolf wrote: > >After searching the net a bit and trying out some things myself, I'm > >afraid that this approach doesn't work. It does seem to do the right > >thing when build and runtime version are the same, but n

Re: [Qemu-devel] [PATCH 2/2] rbd: disable unsupported librbd functions at runtime

2013-04-04 Thread Josh Durgin
On 04/04/2013 03:10 AM, Kevin Wolf wrote: Am 04.04.2013 um 10:35 hat Josh Durgin geschrieben: QEMU may be compiled against a newer version of librbd, but run and dynamically linked with an older version that does not support these functions. Declare them as weak symbols so they can be checked fo

Re: [Qemu-devel] [PATCH 2/2] rbd: disable unsupported librbd functions at runtime

2013-04-04 Thread Kevin Wolf
Am 04.04.2013 um 10:35 hat Josh Durgin geschrieben: > QEMU may be compiled against a newer version of librbd, but run and > dynamically linked with an older version that does not support these > functions. Declare them as weak symbols so they can be checked for > existence at runtime. > > Only rbd

[Qemu-devel] [PATCH 2/2] rbd: disable unsupported librbd functions at runtime

2013-04-04 Thread Josh Durgin
QEMU may be compiled against a newer version of librbd, but run and dynamically linked with an older version that does not support these functions. Declare them as weak symbols so they can be checked for existence at runtime. Only rbd_aio_discard, rbd_aio_flush, and rbd_flush were added after the