Re: [Qemu-devel] [PATCH 2/2] slirp: Don't mark struct ipq or struct ipasfrag as packed

2019-01-22 Thread Eric Blake
On 1/22/19 12:18 PM, Peter Maydell wrote: > There is no reason to mark the struct ipq and struct ipasfrag as > packed: they are naturally aligned anyway, and are not representing > any on-the-wire packet format. Indeed they vary in size depending on > the size of pointers on the host system, becau

Re: [Qemu-devel] [PATCH 2/2] slirp: Don't mark struct ipq or struct ipasfrag as packed

2019-01-22 Thread Peter Maydell
On Tue, 22 Jan 2019 at 18:55, Daniel P. Berrangé wrote: > > On Tue, Jan 22, 2019 at 06:18:22PM +, Peter Maydell wrote: > > There is no reason to mark the struct ipq and struct ipasfrag as > > packed: they are naturally aligned anyway, and are not representing > > any on-the-wire packet format.

Re: [Qemu-devel] [PATCH 2/2] slirp: Don't mark struct ipq or struct ipasfrag as packed

2019-01-22 Thread Daniel P . Berrangé
On Tue, Jan 22, 2019 at 06:18:22PM +, Peter Maydell wrote: > There is no reason to mark the struct ipq and struct ipasfrag as > packed: they are naturally aligned anyway, and are not representing > any on-the-wire packet format. Indeed they vary in size depending on > the size of pointers on t

[Qemu-devel] [PATCH 2/2] slirp: Don't mark struct ipq or struct ipasfrag as packed

2019-01-22 Thread Peter Maydell
There is no reason to mark the struct ipq and struct ipasfrag as packed: they are naturally aligned anyway, and are not representing any on-the-wire packet format. Indeed they vary in size depending on the size of pointers on the host system, because the 'struct qlink' members include 'void *' fie