Re: [Qemu-devel] [PATCH 2/2] strtosz(): Use suffix macros in switch() statement

2011-01-19 Thread Jes Sorensen
On 01/18/11 21:39, Anthony Liguori wrote: > On 01/18/2011 02:36 PM, Jes Sorensen wrote: >> On 01/18/11 21:30, Anthony Liguori wrote: >>> On 01/18/2011 10:53 AM, Eric Blake wrote: And it does, via the toupper() added earlier in the series (and which has separately been pointed out

Re: [Qemu-devel] [PATCH 2/2] strtosz(): Use suffix macros in switch() statement

2011-01-18 Thread Anthony Liguori
On 01/18/2011 02:36 PM, Jes Sorensen wrote: On 01/18/11 21:30, Anthony Liguori wrote: On 01/18/2011 10:53 AM, Eric Blake wrote: On 01/18/2011 09:50 AM, Anthony Liguori wrote: @@ -324,26 +324,26 @@ ssize_t strtosz_suffix(const char *nptr, char **end, const char default_suffix

Re: [Qemu-devel] [PATCH 2/2] strtosz(): Use suffix macros in switch() statement

2011-01-18 Thread Jes Sorensen
On 01/18/11 21:30, Anthony Liguori wrote: > On 01/18/2011 10:53 AM, Eric Blake wrote: >> On 01/18/2011 09:50 AM, Anthony Liguori wrote: >> > @@ -324,26 +324,26 @@ ssize_t strtosz_suffix(const char *nptr, char > **end, const char default_suffix) >} >} >

Re: [Qemu-devel] [PATCH 2/2] strtosz(): Use suffix macros in switch() statement

2011-01-18 Thread Anthony Liguori
On 01/18/2011 10:53 AM, Eric Blake wrote: On 01/18/2011 09:50 AM, Anthony Liguori wrote: @@ -324,26 +324,26 @@ ssize_t strtosz_suffix(const char *nptr, char **end, const char default_suffix) } } switch (toupper(d)) { BTW, a useful change would be to accept

Re: [Qemu-devel] [PATCH 2/2] strtosz(): Use suffix macros in switch() statement

2011-01-18 Thread Eric Blake
On 01/18/2011 09:50 AM, Anthony Liguori wrote: >>> @@ -324,26 +324,26 @@ ssize_t strtosz_suffix(const char *nptr, char >>> **end, const char default_suffix) >>> } >>> } >>> switch (toupper(d)) { > BTW, a useful change would be to accept both upper and lower case letters. And

Re: [Qemu-devel] [PATCH 2/2] strtosz(): Use suffix macros in switch() statement

2011-01-18 Thread Jes Sorensen
On 01/18/11 17:50, Anthony Liguori wrote: > On 01/18/2011 03:20 AM, Markus Armbruster wrote: >> jes.soren...@redhat.com writes: >> >> >>> From: Jes Sorensen >>> >>> Signed-off-by: Jes Sorensen >>> --- >>> cutils.c | 10 +- >>> 1 files changed, 5 insertions(+), 5 deletions(-) >>> >>>

Re: [Qemu-devel] [PATCH 2/2] strtosz(): Use suffix macros in switch() statement

2011-01-18 Thread Anthony Liguori
On 01/18/2011 03:20 AM, Markus Armbruster wrote: jes.soren...@redhat.com writes: From: Jes Sorensen Signed-off-by: Jes Sorensen --- cutils.c | 10 +- 1 files changed, 5 insertions(+), 5 deletions(-) diff --git a/cutils.c b/cutils.c index 328738c..f2c8bbd 100644 --- a/cutils.c

Re: [Qemu-devel] [PATCH 2/2] strtosz(): Use suffix macros in switch() statement

2011-01-18 Thread Alex Williamson
On Tue, 2011-01-18 at 10:20 +0100, Markus Armbruster wrote: > jes.soren...@redhat.com writes: > > > From: Jes Sorensen > > > > Signed-off-by: Jes Sorensen > > --- > > cutils.c | 10 +- > > 1 files changed, 5 insertions(+), 5 deletions(-) > > > > diff --git a/cutils.c b/cutils.c > > in

Re: [Qemu-devel] [PATCH 2/2] strtosz(): Use suffix macros in switch() statement

2011-01-18 Thread Markus Armbruster
jes.soren...@redhat.com writes: > From: Jes Sorensen > > Signed-off-by: Jes Sorensen > --- > cutils.c | 10 +- > 1 files changed, 5 insertions(+), 5 deletions(-) > > diff --git a/cutils.c b/cutils.c > index 328738c..f2c8bbd 100644 > --- a/cutils.c > +++ b/cutils.c > @@ -324,26 +324,26

Re: [Qemu-devel] [PATCH 2/2] strtosz(): Use suffix macros in switch() statement

2011-01-18 Thread Jes Sorensen
On 01/18/11 10:20, Markus Armbruster wrote: >> diff --git a/cutils.c b/cutils.c >> index 328738c..f2c8bbd 100644 >> --- a/cutils.c >> +++ b/cutils.c >> @@ -324,26 +324,26 @@ ssize_t strtosz_suffix(const char *nptr, char **end, >> const char default_suffix) >> } >> } >> switch (t

[Qemu-devel] [PATCH 2/2] strtosz(): Use suffix macros in switch() statement

2011-01-17 Thread Jes . Sorensen
From: Jes Sorensen Signed-off-by: Jes Sorensen --- cutils.c | 10 +- 1 files changed, 5 insertions(+), 5 deletions(-) diff --git a/cutils.c b/cutils.c index 328738c..f2c8bbd 100644 --- a/cutils.c +++ b/cutils.c @@ -324,26 +324,26 @@ ssize_t strtosz_suffix(const char *nptr, char **end