Paolo Bonzini wrote:
>
>
> On 13/04/2015 01:32, Nadav Amit wrote:
>> +if (kvm_check_extension(s, KVM_CAP_ENABLE_CAP_VM)) {
>
> The right capability to check here is KVM_CAP_DISABLE_QUIRKS, not
> KVM_CAP_ENABLE_CAP_VM.
>
> Paolo
>
>> +ret = kvm_vm_enable_cap(s, KVM_CAP_DISABLE_QUI
Paolo Bonzini wrote:
>
>
> On 13/04/2015 16:17, Nadav Amit wrote:
>> Paolo Bonzini wrote:
>>
>>> On 13/04/2015 01:32, Nadav Amit wrote:
+if (kvm_check_extension(s, KVM_CAP_ENABLE_CAP_VM)) {
>>>
>>> The right capability to check here is KVM_CAP_DISABLE_QUIRKS, not
>>> KVM_CAP_ENABLE_
On 13/04/2015 16:33, Nadav Amit wrote:
>>> >> Of course…
>>> >> Do you want a v2 now, later (after 4.2), or would you change it yourself?
>> >
>> > Later, close to 4.2 but not necessarily after it.
> Anyhow, in that case the KVM patch is also wrong (not reporting
> KVM_CAP_DISABLE_QUIRKS is supp
On 13/04/2015 16:17, Nadav Amit wrote:
> Paolo Bonzini wrote:
>
>>
>>
>> On 13/04/2015 01:32, Nadav Amit wrote:
>>> +if (kvm_check_extension(s, KVM_CAP_ENABLE_CAP_VM)) {
>>
>> The right capability to check here is KVM_CAP_DISABLE_QUIRKS, not
>> KVM_CAP_ENABLE_CAP_VM.
>>
>> Paolo
>>
>>> +
On 13/04/2015 01:32, Nadav Amit wrote:
> +if (kvm_check_extension(s, KVM_CAP_ENABLE_CAP_VM)) {
The right capability to check here is KVM_CAP_DISABLE_QUIRKS, not
KVM_CAP_ENABLE_CAP_VM.
Paolo
> +ret = kvm_vm_enable_cap(s, KVM_CAP_DISABLE_QUIRKS, 0,
> +
KVM has quirks to overcome legacy QEMU bugs that are already resolved. Using a
new KVM feature for disabling these quirks.
Signed-off-by: Nadav Amit
---
linux-headers/asm-x86/kvm.h | 4
linux-headers/linux/kvm.h | 1 +
target-i386/kvm.c | 8
3 files changed, 13 inserti
