[Qemu-devel] [PATCH 2/2] tracetool: Forbid argument name 'next'

2012-03-12 Thread Kevin Wolf
It has happened more than once that patches that look perfectly sane and work with simpletrace broke systemtap because they use 'next' as an argument name for a tracing function. However, 'next' is a keyword for systemtap, so we shouldn't use it. Signed-off-by: Kevin Wolf kw...@redhat.com ---

Re: [Qemu-devel] [PATCH 2/2] tracetool: Forbid argument name 'next'

2012-03-12 Thread Stefan Hajnoczi
On Mon, Mar 12, 2012 at 9:34 AM, Kevin Wolf kw...@redhat.com wrote: It has happened more than once that patches that look perfectly sane and work with simpletrace broke systemtap because they use 'next' as an argument name for a tracing function. However, 'next' is a keyword for systemtap, so

Re: [Qemu-devel] [PATCH 2/2] tracetool: Forbid argument name 'next'

2012-03-12 Thread Kevin Wolf
Am 12.03.2012 12:01, schrieb Stefan Hajnoczi: On Mon, Mar 12, 2012 at 9:34 AM, Kevin Wolf kw...@redhat.com wrote: It has happened more than once that patches that look perfectly sane and work with simpletrace broke systemtap because they use 'next' as an argument name for a tracing function.

Re: [Qemu-devel] [PATCH 2/2] tracetool: Forbid argument name 'next'

2012-03-12 Thread LluĂ­s Vilanova
Stefan Hajnoczi writes: On Mon, Mar 12, 2012 at 9:34 AM, Kevin Wolf kw...@redhat.com wrote: It has happened more than once that patches that look perfectly sane and work with simpletrace broke systemtap because they use 'next' as an argument name for a tracing function. However, 'next' is a