Re: [Qemu-devel] [PATCH 2/2] ui/cocoa: fix grabbing issue in fullscreen mode

2019-03-18 Thread Peter Maydell
On Fri, 15 Mar 2019 at 09:37, Chen Zhang wrote: > > Signed-off-by: Chen Zhang Again, it would be nice to see a commit message here that explained what was being changed and why. If you take my suggestion from my review of patch 1 this is no longer relevant, but: > @@ -881,7 +900,7 @@ QemuCocoa

[Qemu-devel] [PATCH 2/2] ui/cocoa: fix grabbing issue in fullscreen mode

2019-03-15 Thread Chen Zhang via Qemu-devel
Signed-off-by: Chen Zhang mailto:tgfb...@me.com>> --- ui/cocoa.m | 35 +++ 1 file changed, 27 insertions(+), 8 deletions(-) diff --git a/ui/cocoa.m b/ui/cocoa.m index 5d0a6599d9..8e74f6e283 100644 --- a/ui/cocoa.m +++ b/ui/cocoa.m @@ -410,11 +410,31 @@ QemuCocoaView

[Qemu-devel] [PATCH 2/2] ui/cocoa: fix grabbing issue in fullscreen mode

2019-03-15 Thread Chen Zhang via Qemu-devel
Signed-off-by: Chen Zhang --- ui/cocoa.m | 35 +++ 1 file changed, 27 insertions(+), 8 deletions(-) diff --git a/ui/cocoa.m b/ui/cocoa.m index 5d0a6599d9..8e74f6e283 100644 --- a/ui/cocoa.m +++ b/ui/cocoa.m @@ -410,11 +410,31 @@ QemuCocoaView *cocoaView; { N