Re: [Qemu-devel] [PATCH 2/2] vhost-user: only seek a reply if needed in set_mem_table

2016-09-12 Thread Maxime Coquelin
On 09/08/2016 05:15 PM, Michael S. Tsirkin wrote: On Thu, Sep 08, 2016 at 10:34:10AM +0200, Maxime Coquelin wrote: The goal of this patch is to only request a sync (reply_ack, or get_features) in set_mem_table only when necessary. It should not be necessary the first time we set the table, or

Re: [Qemu-devel] [PATCH 2/2] vhost-user: only seek a reply if needed in set_mem_table

2016-09-08 Thread Michael S. Tsirkin
On Thu, Sep 08, 2016 at 10:34:10AM +0200, Maxime Coquelin wrote: > The goal of this patch is to only request a sync (reply_ack, > or get_features) in set_mem_table only when necessary. > > It should not be necessary the first time we set the table, > or when we add a new regions which hadn't been

Re: [Qemu-devel] [PATCH 2/2] vhost-user: only seek a reply if needed in set_mem_table

2016-09-08 Thread Michael S. Tsirkin
On Thu, Sep 08, 2016 at 11:33:34AM +, Prerna Saxena wrote: > Hi Maxime, > > > On 08/09/16 2:04 pm, "Maxime Coquelin" wrote: > > >The goal of this patch is to only request a sync (reply_ack, > >or get_features) in set_mem_table only when necessary. > > > >It should not be necessary the first

Re: [Qemu-devel] [PATCH 2/2] vhost-user: only seek a reply if needed in set_mem_table

2016-09-08 Thread Michael S. Tsirkin
On Thu, Sep 08, 2016 at 07:56:38AM -0400, Marc-André Lureau wrote: > Hi > > - Original Message - > > Regarding Patch 2/2: > > This patch seems to filter responses from set_mem_table only for certain > > updates of memory regions. It violates the definition of the REPLY_ACK > > feature. Thi

Re: [Qemu-devel] [PATCH 2/2] vhost-user: only seek a reply if needed in set_mem_table

2016-09-08 Thread Marc-André Lureau
Hi - Original Message - > Regarding Patch 2/2: > This patch seems to filter responses from set_mem_table only for certain > updates of memory regions. It violates the definition of the REPLY_ACK > feature. This feature expects the client to send a response for every call > of set_mem_table

Re: [Qemu-devel] [PATCH 2/2] vhost-user: only seek a reply if needed in set_mem_table

2016-09-08 Thread Prerna Saxena
Hi Maxime, On 08/09/16 2:04 pm, "Maxime Coquelin" wrote: >The goal of this patch is to only request a sync (reply_ack, >or get_features) in set_mem_table only when necessary. > >It should not be necessary the first time we set the table, >or when we add a new regions which hadn't been merged wi

[Qemu-devel] [PATCH 2/2] vhost-user: only seek a reply if needed in set_mem_table

2016-09-08 Thread Maxime Coquelin
The goal of this patch is to only request a sync (reply_ack, or get_features) in set_mem_table only when necessary. It should not be necessary the first time we set the table, or when we add a new regions which hadn't been merged with an existing ones. Suggested-by: Michael S. Tsirkin Cc: Prerna