Re: [Qemu-devel] [PATCH 2/2] virtio-balloon: resume collecting stats on vmload

2016-09-06 Thread Michael S. Tsirkin
On Tue, Sep 06, 2016 at 09:50:00AM +0300, Roman Kagan wrote: > On Tue, Sep 06, 2016 at 04:45:13AM +0300, Michael S. Tsirkin wrote: > > On Mon, Sep 05, 2016 at 11:02:36AM +0300, Roman Kagan wrote: > > > On Sat, Sep 03, 2016 at 01:53:53AM +0300, Michael S. Tsirkin wrote: > > > > On Fri, Sep 02, 2016

Re: [Qemu-devel] [PATCH 2/2] virtio-balloon: resume collecting stats on vmload

2016-09-06 Thread Roman Kagan
On Tue, Sep 06, 2016 at 04:45:13AM +0300, Michael S. Tsirkin wrote: > On Mon, Sep 05, 2016 at 11:02:36AM +0300, Roman Kagan wrote: > > On Sat, Sep 03, 2016 at 01:53:53AM +0300, Michael S. Tsirkin wrote: > > > On Fri, Sep 02, 2016 at 10:21:58AM +0300, Roman Kagan wrote: > > > > On Thu, Sep 01, 2016

Re: [Qemu-devel] [PATCH 2/2] virtio-balloon: resume collecting stats on vmload

2016-09-05 Thread Michael S. Tsirkin
On Mon, Sep 05, 2016 at 11:02:36AM +0300, Roman Kagan wrote: > On Sat, Sep 03, 2016 at 01:53:53AM +0300, Michael S. Tsirkin wrote: > > On Fri, Sep 02, 2016 at 10:21:58AM +0300, Roman Kagan wrote: > > > On Thu, Sep 01, 2016 at 10:26:54PM +0300, Michael S. Tsirkin wrote: > > > > I'm sorry - I don't l

Re: [Qemu-devel] [PATCH 2/2] virtio-balloon: resume collecting stats on vmload

2016-09-05 Thread Roman Kagan
On Sat, Sep 03, 2016 at 01:53:53AM +0300, Michael S. Tsirkin wrote: > On Fri, Sep 02, 2016 at 10:21:58AM +0300, Roman Kagan wrote: > > On Thu, Sep 01, 2016 at 10:26:54PM +0300, Michael S. Tsirkin wrote: > > > I'm sorry - I don't like this patch. This means that > > > virtio_balloon_receive_stats wi

Re: [Qemu-devel] [PATCH 2/2] virtio-balloon: resume collecting stats on vmload

2016-09-02 Thread Michael S. Tsirkin
On Fri, Sep 02, 2016 at 10:21:58AM +0300, Roman Kagan wrote: > On Thu, Sep 01, 2016 at 10:26:54PM +0300, Michael S. Tsirkin wrote: > > On Thu, Sep 01, 2016 at 09:14:00PM +0300, Roman Kagan wrote: > > > Upon save/restore virtio-balloon stats acquisition stops. The reason is > > > that the in-use vi

Re: [Qemu-devel] [PATCH 2/2] virtio-balloon: resume collecting stats on vmload

2016-09-02 Thread Roman Kagan
On Thu, Sep 01, 2016 at 10:26:54PM +0300, Michael S. Tsirkin wrote: > On Thu, Sep 01, 2016 at 09:14:00PM +0300, Roman Kagan wrote: > > Upon save/restore virtio-balloon stats acquisition stops. The reason is > > that the in-use virtqueue element is not saved, and upon restore it's > > not released

Re: [Qemu-devel] [PATCH 2/2] virtio-balloon: resume collecting stats on vmload

2016-09-01 Thread Michael S. Tsirkin
On Thu, Sep 01, 2016 at 09:14:00PM +0300, Roman Kagan wrote: > Upon save/restore virtio-balloon stats acquisition stops. The reason is > that the in-use virtqueue element is not saved, and upon restore it's > not released to the guest, making further progress impossible. > > Saving the informatio

[Qemu-devel] [PATCH 2/2] virtio-balloon: resume collecting stats on vmload

2016-09-01 Thread Roman Kagan
Upon save/restore virtio-balloon stats acquisition stops. The reason is that the in-use virtqueue element is not saved, and upon restore it's not released to the guest, making further progress impossible. Saving the information about the used element would introduce unjustified vmstate incompatib