Re: [Qemu-devel] [PATCH 2/2] vmdk: fix cluster size check for flat extents

2013-09-21 Thread Fam Zheng
On Fri, 09/20 17:04, Paolo Bonzini wrote: > Il 19/09/2013 13:31, Stefan Hajnoczi ha scritto: > >> > We use the extent size as cluster size for flat extents (where no L1/L2 > >> > table is allocated so it's safe). > > Why is the extent size passed as the cluster size parameter? > > I think it's so

Re: [Qemu-devel] [PATCH 2/2] vmdk: fix cluster size check for flat extents

2013-09-20 Thread Paolo Bonzini
Il 19/09/2013 13:31, Stefan Hajnoczi ha scritto: >> > We use the extent size as cluster size for flat extents (where no L1/L2 >> > table is allocated so it's safe). > Why is the extent size passed as the cluster size parameter? I think it's so that the flat extent doesn't take up too many cache en

Re: [Qemu-devel] [PATCH 2/2] vmdk: fix cluster size check for flat extents

2013-09-19 Thread Stefan Hajnoczi
On Wed, Sep 18, 2013 at 07:14:15PM +0800, Fam Zheng wrote: > We use the extent size as cluster size for flat extents (where no L1/L2 > table is allocated so it's safe). Why is the extent size passed as the cluster size parameter? The cleaner fix would be to stop passing it as cluster size :). St

[Qemu-devel] [PATCH 2/2] vmdk: fix cluster size check for flat extents

2013-09-18 Thread Fam Zheng
We use the extent size as cluster size for flat extents (where no L1/L2 table is allocated so it's safe). So don't check the cluster size for flat case in opening. Otherwise flat extent opening is broken: # qemu-img create -f vmdk -o subformat=monolithicFlat /tmp/a.vmdk 100G Formatting '