Re: [Qemu-devel] [PATCH 2/3] Migration/colo.c: Fix COLO failover status error

2019-02-28 Thread Zhang, Chen
-Original Message- From: Dr. David Alan Gilbert [mailto:dgilb...@redhat.com] Sent: Thursday, February 28, 2019 9:03 PM To: Zhang, Chen Cc: Li Zhijian ; Zhang Chen ; Juan Quintela ; zhanghailiang ; qemu-dev Subject: Re: [PATCH 2/3] Migration/colo.c: Fix COLO failover status error *

Re: [Qemu-devel] [PATCH 2/3] Migration/colo.c: Fix COLO failover status error

2019-02-28 Thread Dr. David Alan Gilbert
* Zhang, Chen (chen.zh...@intel.com) wrote: > > -Original Message- > From: Dr. David Alan Gilbert [mailto:dgilb...@redhat.com] > Sent: Tuesday, February 26, 2019 6:55 PM > To: Zhang, Chen > Cc: Li Zhijian ; Zhang Chen ; > Juan Quintela ; zhanghailiang > ; qemu-dev > Subject: Re: [PATC

Re: [Qemu-devel] [PATCH 2/3] Migration/colo.c: Fix COLO failover status error

2019-02-26 Thread Zhang, Chen
-Original Message- From: Dr. David Alan Gilbert [mailto:dgilb...@redhat.com] Sent: Tuesday, February 26, 2019 6:55 PM To: Zhang, Chen Cc: Li Zhijian ; Zhang Chen ; Juan Quintela ; zhanghailiang ; qemu-dev Subject: Re: [PATCH 2/3] Migration/colo.c: Fix COLO failover status error * Zh

Re: [Qemu-devel] [PATCH 2/3] Migration/colo.c: Fix COLO failover status error

2019-02-26 Thread Dr. David Alan Gilbert
* Zhang Chen (chen.zh...@intel.com) wrote: > From: Zhang Chen > > When finished COLO failover, the status is FAILOVER_STATUS_COMPLETED. > The origin codes misunderstand the FAILOVER_STATUS_REQUIRE. > > Signed-off-by: Zhang Chen Why do these 'case's have to only deal with COMPLETED - what stops

[Qemu-devel] [PATCH 2/3] Migration/colo.c: Fix COLO failover status error

2019-02-25 Thread Zhang Chen
From: Zhang Chen When finished COLO failover, the status is FAILOVER_STATUS_COMPLETED. The origin codes misunderstand the FAILOVER_STATUS_REQUIRE. Signed-off-by: Zhang Chen --- migration/colo.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/migration/colo.c b/migrat