Re: [Qemu-devel] [PATCH 2/3] QMP: Drop dead code

2010-12-14 Thread Markus Armbruster
Luiz Capitulino lcapitul...@redhat.com writes: The first if/else clause in handler_audit() makes no sense for two reasons: 1. this function is now called only by QMP code, so testing if it's a QMP call makes no sense anymore 2. the else clause first asserts that there's no error

[Qemu-devel] [PATCH 2/3] QMP: Drop dead code

2010-11-23 Thread Luiz Capitulino
The first if/else clause in handler_audit() makes no sense for two reasons: 1. this function is now called only by QMP code, so testing if it's a QMP call makes no sense anymore 2. the else clause first asserts that there's no error in the monitor object, then it tries to free it!