Re: [Qemu-devel] [PATCH 2/3] Update the blkmirror block driver

2012-02-23 Thread Federico Simoncelli
- Original Message - From: Paolo Bonzini pbonz...@redhat.com To: Federico Simoncelli fsimo...@redhat.com Cc: qemu-devel@nongnu.org, kw...@redhat.com, mtosa...@redhat.com Sent: Thursday, February 23, 2012 8:18:28 AM Subject: Re: [PATCH 2/3] Update the blkmirror block driver On

Re: [Qemu-devel] [PATCH 2/3] Update the blkmirror block driver

2012-02-23 Thread Paolo Bonzini
On 02/23/2012 10:44 AM, Federico Simoncelli wrote: Any comment on the BDRV_O_NO_BACKING flag I added? That's the real trick I'm pulling here. It basically allows to open the second image only for writing and it doesn't complain if the backing file is not there yet (it will be copied during

[Qemu-devel] [PATCH 2/3] Update the blkmirror block driver

2012-02-22 Thread Federico Simoncelli
Signed-off-by: Federico Simoncelli fsimo...@redhat.com --- block/blkmirror.c | 26 +- 1 files changed, 13 insertions(+), 13 deletions(-) diff --git a/block/blkmirror.c b/block/blkmirror.c index 1c02710..1cfd2fb 100644 --- a/block/blkmirror.c +++ b/block/blkmirror.c @@

Re: [Qemu-devel] [PATCH 2/3] Update the blkmirror block driver

2012-02-22 Thread Paolo Bonzini
On 02/22/2012 06:13 PM, Federico Simoncelli wrote: @@ -46,7 +46,7 @@ static int blkmirror_open(BlockDriverState *bs, const char *filename, int flags) filename += strlen(blkmirror:); /* Parse the raw image filename */ -filename2 = qemu_malloc(strlen(filename)+1); +