Re: [Qemu-devel] [PATCH 2/3] VCPU hotplug support

2012-01-24 Thread Jan Kiszka
On 2012-01-24 17:24, Igor Mammedov wrote: > On 01/23/2012 06:55 PM, Jan Kiszka wrote: >> On 2012-01-23 17:29, Igor Mammedov wrote: >>> On 01/17/2012 03:17 PM, Jan Kiszka wrote: >>> >>> It seams that "env->cpuid_apic_id = cpu" is pointless especcialy >>> taking in account that in cpu_x86_init cpuid_

Re: [Qemu-devel] [PATCH 2/3] VCPU hotplug support

2012-01-24 Thread Igor Mammedov
On 01/23/2012 06:55 PM, Jan Kiszka wrote: On 2012-01-23 17:29, Igor Mammedov wrote: On 01/17/2012 03:17 PM, Jan Kiszka wrote: It seams that "env->cpuid_apic_id = cpu" is pointless especcialy taking in account that in cpu_x86_init cpuid_apic_id is initialized by cpu_index. What we gain in having

Re: [Qemu-devel] [PATCH 2/3] VCPU hotplug support

2012-01-23 Thread Jan Kiszka
On 2012-01-23 17:29, Igor Mammedov wrote: > On 01/17/2012 03:17 PM, Jan Kiszka wrote: >> On 2012-01-17 14:17, Igor Mammedov wrote: >>> Rebase of the missing bits from qemu-kvm for vcpu hotplug >> >> Description, please. Please try to split up, at least into PIIX4 >> preparations and "the rest". May

Re: [Qemu-devel] [PATCH 2/3] VCPU hotplug support

2012-01-23 Thread Igor Mammedov
On 01/17/2012 03:17 PM, Jan Kiszka wrote: On 2012-01-17 14:17, Igor Mammedov wrote: Rebase of the missing bits from qemu-kvm for vcpu hotplug Description, please. Please try to split up, at least into PIIX4 preparations and "the rest". Maybe also a patch for a generic CPU hotplug infrastructur

Re: [Qemu-devel] [PATCH 2/3] VCPU hotplug support

2012-01-17 Thread Jan Kiszka
On 2012-01-17 15:17, Jan Kiszka wrote: >> >> /* output Bochs bios info messages */ >> //#define DEBUG_BIOS >> @@ -930,10 +932,22 @@ static void pc_cpu_reset(void *opaque) >> env->halted = !cpu_is_bsp(env); >> } >> >> -static CPUState *pc_new_cpu(const char *cpu_model) >> +CPUState *pc_n

Re: [Qemu-devel] [PATCH 2/3] VCPU hotplug support

2012-01-17 Thread Jan Kiszka
On 2012-01-17 14:17, Igor Mammedov wrote: > Rebase of the missing bits from qemu-kvm for vcpu hotplug Description, please. Please try to split up, at least into PIIX4 preparations and "the rest". Maybe also a patch for a generic CPU hotplug infrastructure. > > Signed-off-by: Igor Mammedov > ---

[Qemu-devel] [PATCH 2/3] VCPU hotplug support

2012-01-17 Thread Igor Mammedov
Rebase of the missing bits from qemu-kvm for vcpu hotplug Signed-off-by: Igor Mammedov --- Makefile.objs |2 +- Makefile.target |2 +- hw/acpi_piix4.c | 83 ++-- hw/pc.c | 21 +- hw/pc_piix.c |4 ++