On 02/27/2013 06:52 PM, mdroth wrote:
On Wed, Feb 27, 2013 at 06:24:45PM -0500, Stefan Berger wrote:
This is actually exactly what test-visitor-serialization.c does. It
feeds various normal/corner cases of visit_type_* into your output
visitor, takes that output and feeds it back into the input
On 02/27/2013 03:28 AM, Andreas Färber wrote:
Am 27.02.2013 00:03, schrieb jsch...@linux.vnet.ibm.com:
[snip]
I wrote an ASN.1 implementation once, and it seems to me you are mixing
up ASN.1 and BER here in your enum/array/... naming. The types are
general ASN.1 concepts and apply to other enco
Il 27/02/2013 23:11, mdroth ha scritto:
>> > As for the location of the source files I think where the patch puts
>> > them now makes most sense, I don't think qapi makes sense. But the
>> > location isn't important to me so I'll put them wherever. Anybody
>> > else have an opinion on the best lo
On Wed, Feb 27, 2013 at 06:24:45PM -0500, Stefan Berger wrote:
> On 02/27/2013 05:57 PM, mdroth wrote:
> >On Tue, Feb 26, 2013 at 05:03:56PM -0600, jsch...@linux.vnet.ibm.com wrote:
> >>These patches implement asn1 ber visitors for encoding and decoding data.
> >>References: <20130226230354.982917.
On 02/27/2013 05:57 PM, mdroth wrote:
On Tue, Feb 26, 2013 at 05:03:56PM -0600, jsch...@linux.vnet.ibm.com wrote:
These patches implement asn1 ber visitors for encoding and decoding data.
References: <20130226230354.982917...@linux.vnet.ibm.com>
Content-Disposition: inline; filename=asn1_all.dif
On Wed, Feb 27, 2013 at 02:03:45PM -0600, Joel Schopp wrote:
> Thanks for the feedback.
>
> On 02/27/2013 02:28 AM, Andreas Färber wrote:
> >Am 27.02.2013 00:03, schrieb jsch...@linux.vnet.ibm.com:
> >>These patches implement asn1 ber visitors for encoding and decoding data.
> >
> >Would be good t
Il 27/02/2013 21:03, Joel Schopp ha scritto:
>
>>> +ber-nested-y = ber-input-visitor.o ber-output-visitor.o ber-common.o
>>> +ber-obj-y = $(addprefix ber/, $(ber-nested-y))
>>> +
>>> +common-obj-y += qemu-char.o qemu-file.o $(ber-obj-y) #aio.o
>>
>> I don't see any justification for that statement
Thanks for the feedback.
On 02/27/2013 02:28 AM, Andreas Färber wrote:
Am 27.02.2013 00:03, schrieb jsch...@linux.vnet.ibm.com:
These patches implement asn1 ber visitors for encoding and decoding data.
Would be good to not be lazy and spell them correctly in at least one of
the two lines of t
Am 27.02.2013 00:03, schrieb jsch...@linux.vnet.ibm.com:
> These patches implement asn1 ber visitors for encoding and decoding data.
Would be good to not be lazy and spell them correctly in at least one of
the two lines of the commit where they're being introduced.
> References: <20130226230354.9
